xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iwl4965: Fix more memory leaks in __il4965_up()

Browse Source 
In some of the non-success return paths, the memory allocated by
iwl4965_sta_alloc_lq() in iwl4965_alloc_bcast_station() is not freed.

In particular:
 - if the card isn't ready after il4965_prepare_card_hw()
 - if the card is hardware-rfkilled

In the hardware rfkilled path, the driver enables the rfkill
interrupt. When the card is unrfkilled and this interrupt is raised
we end up calling il4965_bg_restart() which calls __il4965_up() which
calls iwl4965_alloc_bcast_station() again.

Suggested-by: Jia-Ju Bai <baijiaju1990@163.com>
Signed-off-by: Julian Calaby <julian.calaby@gmail.com>
Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This commit is contained in:
Julian Calaby
2016-03-18 13:29:11 +11:00
committed by Kalle Valo
parent c2fd34469d
commit 84d17a2a5a
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/wireless/intel/iwlegacy/4965-mac.c
View File

@@ -5553,6 +5553,7 @@ __il4965_up(struct il_priv *il)
il4965_prepare_card_hw(il); il4965_prepare_card_hw(il);
if (!il->hw_ready) { if (!il->hw_ready) {
il_dealloc_bcast_stations(il);
IL_ERR("HW not ready\n"); IL_ERR("HW not ready\n");
return -EIO; return -EIO;
} }
@@ -5564,6 +5565,7 @@ __il4965_up(struct il_priv *il)
set_bit(S_RFKILL, &il->status); set_bit(S_RFKILL, &il->status);
wiphy_rfkill_set_hw_state(il->hw->wiphy, true); wiphy_rfkill_set_hw_state(il->hw->wiphy, true);
il_dealloc_bcast_stations(il);
il_enable_rfkill_int(il); il_enable_rfkill_int(il);
IL_WARN("Radio disabled by HW RF Kill switch\n"); IL_WARN("Radio disabled by HW RF Kill switch\n");
return 0; return 0;