xfs: devirtualize ->sf_get_parent_ino and ->sf_put_parent_ino
The parent inode handling is the same for all directory format variants, just use direct calls instead of going through a pointless indirect call. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
This commit is contained in:

committed by
Darrick J. Wong

parent
3d92c93b70
commit
84915e1bdd
@@ -125,7 +125,7 @@ xfs_dir2_block_sfsize(
|
||||
*/
|
||||
sfhp->count = count;
|
||||
sfhp->i8count = i8count;
|
||||
dp->d_ops->sf_put_parent_ino(sfhp, parent);
|
||||
xfs_dir2_sf_put_parent_ino(sfhp, parent);
|
||||
return size;
|
||||
}
|
||||
|
||||
@@ -204,7 +204,7 @@ xfs_dir2_block_to_sf(
|
||||
else if (dep->namelen == 2 &&
|
||||
dep->name[0] == '.' && dep->name[1] == '.')
|
||||
ASSERT(be64_to_cpu(dep->inumber) ==
|
||||
dp->d_ops->sf_get_parent_ino(sfp));
|
||||
xfs_dir2_sf_get_parent_ino(sfp));
|
||||
/*
|
||||
* Normal entry, copy it into shortform.
|
||||
*/
|
||||
@@ -584,7 +584,7 @@ xfs_dir2_sf_check(
|
||||
|
||||
sfp = (xfs_dir2_sf_hdr_t *)dp->i_df.if_u1.if_data;
|
||||
offset = dp->d_ops->data_first_offset;
|
||||
ino = dp->d_ops->sf_get_parent_ino(sfp);
|
||||
ino = xfs_dir2_sf_get_parent_ino(sfp);
|
||||
i8count = ino > XFS_DIR2_MAX_SHORT_INUM;
|
||||
|
||||
for (i = 0, sfep = xfs_dir2_sf_firstentry(sfp);
|
||||
@@ -647,7 +647,7 @@ xfs_dir2_sf_verify(
|
||||
endp = (char *)sfp + size;
|
||||
|
||||
/* Check .. entry */
|
||||
ino = dops->sf_get_parent_ino(sfp);
|
||||
ino = xfs_dir2_sf_get_parent_ino(sfp);
|
||||
i8count = ino > XFS_DIR2_MAX_SHORT_INUM;
|
||||
error = xfs_dir_ino_validate(mp, ino);
|
||||
if (error)
|
||||
@@ -757,7 +757,7 @@ xfs_dir2_sf_create(
|
||||
/*
|
||||
* Now can put in the inode number, since i8count is set.
|
||||
*/
|
||||
dp->d_ops->sf_put_parent_ino(sfp, pino);
|
||||
xfs_dir2_sf_put_parent_ino(sfp, pino);
|
||||
sfp->count = 0;
|
||||
dp->i_d.di_size = size;
|
||||
xfs_dir2_sf_check(args);
|
||||
@@ -806,7 +806,7 @@ xfs_dir2_sf_lookup(
|
||||
*/
|
||||
if (args->namelen == 2 &&
|
||||
args->name[0] == '.' && args->name[1] == '.') {
|
||||
args->inumber = dp->d_ops->sf_get_parent_ino(sfp);
|
||||
args->inumber = xfs_dir2_sf_get_parent_ino(sfp);
|
||||
args->cmpresult = XFS_CMP_EXACT;
|
||||
args->filetype = XFS_DIR3_FT_DIR;
|
||||
return -EEXIST;
|
||||
@@ -984,9 +984,9 @@ xfs_dir2_sf_replace(
|
||||
*/
|
||||
if (args->namelen == 2 &&
|
||||
args->name[0] == '.' && args->name[1] == '.') {
|
||||
ino = dp->d_ops->sf_get_parent_ino(sfp);
|
||||
ino = xfs_dir2_sf_get_parent_ino(sfp);
|
||||
ASSERT(args->inumber != ino);
|
||||
dp->d_ops->sf_put_parent_ino(sfp, args->inumber);
|
||||
xfs_dir2_sf_put_parent_ino(sfp, args->inumber);
|
||||
}
|
||||
/*
|
||||
* Normal entry, look for the name.
|
||||
@@ -1092,7 +1092,7 @@ xfs_dir2_sf_toino4(
|
||||
*/
|
||||
sfp->count = oldsfp->count;
|
||||
sfp->i8count = 0;
|
||||
dp->d_ops->sf_put_parent_ino(sfp, dp->d_ops->sf_get_parent_ino(oldsfp));
|
||||
xfs_dir2_sf_put_parent_ino(sfp, xfs_dir2_sf_get_parent_ino(oldsfp));
|
||||
/*
|
||||
* Copy the entries field by field.
|
||||
*/
|
||||
@@ -1165,7 +1165,7 @@ xfs_dir2_sf_toino8(
|
||||
*/
|
||||
sfp->count = oldsfp->count;
|
||||
sfp->i8count = 1;
|
||||
dp->d_ops->sf_put_parent_ino(sfp, dp->d_ops->sf_get_parent_ino(oldsfp));
|
||||
xfs_dir2_sf_put_parent_ino(sfp, xfs_dir2_sf_get_parent_ino(oldsfp));
|
||||
/*
|
||||
* Copy the entries field by field.
|
||||
*/
|
||||
|
Reference in New Issue
Block a user