drm/omap: Move most omap_dss_driver operations to omap_dss_device_ops
omap_dss_device instances have two ops structures, omap_dss_driver and omap_dss_device_ops. The former is used for devices at the end of the pipeline (a.k.a. display devices), and the latter for intermediate devices. Having two sets of operations isn't convenient as code that iterates over omap_dss_device instances need to take them both into account. There's currently a reasonably small amount of such code, but more will be introduced to move the driver away from recursive operations. To simplify current and future code, move all operations that are not specific to the display device to the omap_dss_device_ops. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
This commit is contained in:

committed by
Tomi Valkeinen

parent
e7df657102
commit
83910ad3f5
@@ -297,18 +297,7 @@ struct omap_dss_writeback_info {
|
||||
};
|
||||
|
||||
struct omapdss_hdmi_ops {
|
||||
int (*read_edid)(struct omap_dss_device *dssdev, u8 *buf, int len);
|
||||
void (*lost_hotplug)(struct omap_dss_device *dssdev);
|
||||
bool (*detect)(struct omap_dss_device *dssdev);
|
||||
|
||||
int (*register_hpd_cb)(struct omap_dss_device *dssdev,
|
||||
void (*cb)(void *cb_data,
|
||||
enum drm_connector_status status),
|
||||
void *cb_data);
|
||||
void (*unregister_hpd_cb)(struct omap_dss_device *dssdev);
|
||||
void (*enable_hpd)(struct omap_dss_device *dssdev);
|
||||
void (*disable_hpd)(struct omap_dss_device *dssdev);
|
||||
|
||||
int (*set_hdmi_mode)(struct omap_dss_device *dssdev, bool hdmi_mode);
|
||||
int (*set_infoframe)(struct omap_dss_device *dssdev,
|
||||
const struct hdmi_avi_infoframe *avi);
|
||||
@@ -376,9 +365,23 @@ struct omap_dss_device_ops {
|
||||
|
||||
int (*check_timings)(struct omap_dss_device *dssdev,
|
||||
struct videomode *vm);
|
||||
void (*get_timings)(struct omap_dss_device *dssdev,
|
||||
struct videomode *vm);
|
||||
void (*set_timings)(struct omap_dss_device *dssdev,
|
||||
struct videomode *vm);
|
||||
|
||||
bool (*detect)(struct omap_dss_device *dssdev);
|
||||
|
||||
int (*register_hpd_cb)(struct omap_dss_device *dssdev,
|
||||
void (*cb)(void *cb_data,
|
||||
enum drm_connector_status status),
|
||||
void *cb_data);
|
||||
void (*unregister_hpd_cb)(struct omap_dss_device *dssdev);
|
||||
void (*enable_hpd)(struct omap_dss_device *dssdev);
|
||||
void (*disable_hpd)(struct omap_dss_device *dssdev);
|
||||
|
||||
int (*read_edid)(struct omap_dss_device *dssdev, u8 *buf, int len);
|
||||
|
||||
union {
|
||||
const struct omapdss_hdmi_ops hdmi;
|
||||
const struct omapdss_dsi_ops dsi;
|
||||
@@ -440,14 +443,6 @@ struct omap_dss_device {
|
||||
};
|
||||
|
||||
struct omap_dss_driver {
|
||||
int (*connect)(struct omap_dss_device *src,
|
||||
struct omap_dss_device *dst);
|
||||
void (*disconnect)(struct omap_dss_device *src,
|
||||
struct omap_dss_device *dst);
|
||||
|
||||
int (*enable)(struct omap_dss_device *display);
|
||||
void (*disable)(struct omap_dss_device *display);
|
||||
|
||||
int (*update)(struct omap_dss_device *dssdev,
|
||||
u16 x, u16 y, u16 w, u16 h);
|
||||
int (*sync)(struct omap_dss_device *dssdev);
|
||||
@@ -459,29 +454,8 @@ struct omap_dss_driver {
|
||||
void *buf, size_t size,
|
||||
u16 x, u16 y, u16 w, u16 h);
|
||||
|
||||
int (*check_timings)(struct omap_dss_device *dssdev,
|
||||
struct videomode *vm);
|
||||
void (*set_timings)(struct omap_dss_device *dssdev,
|
||||
struct videomode *vm);
|
||||
void (*get_timings)(struct omap_dss_device *dssdev,
|
||||
struct videomode *vm);
|
||||
void (*get_size)(struct omap_dss_device *dssdev,
|
||||
unsigned int *width, unsigned int *height);
|
||||
|
||||
int (*read_edid)(struct omap_dss_device *dssdev, u8 *buf, int len);
|
||||
bool (*detect)(struct omap_dss_device *dssdev);
|
||||
|
||||
int (*register_hpd_cb)(struct omap_dss_device *dssdev,
|
||||
void (*cb)(void *cb_data,
|
||||
enum drm_connector_status status),
|
||||
void *cb_data);
|
||||
void (*unregister_hpd_cb)(struct omap_dss_device *dssdev);
|
||||
void (*enable_hpd)(struct omap_dss_device *dssdev);
|
||||
void (*disable_hpd)(struct omap_dss_device *dssdev);
|
||||
|
||||
int (*set_hdmi_mode)(struct omap_dss_device *dssdev, bool hdmi_mode);
|
||||
int (*set_hdmi_infoframe)(struct omap_dss_device *dssdev,
|
||||
const struct hdmi_avi_infoframe *avi);
|
||||
};
|
||||
|
||||
struct dss_device *omapdss_get_dss(void);
|
||||
|
Reference in New Issue
Block a user