xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ceph: ceph_kick_flushing_caps needs the s_mutex

Browse Source 
The mdsc->cap_dirty_lock is not held while walking the list in
ceph_kick_flushing_caps, which is not safe.

ceph_early_kick_flushing_caps does something similar, but the
s_mutex is held while it's called and I think that guards against
changes to the list.

Ensure we hold the s_mutex when calling ceph_kick_flushing_caps,
and add some clarifying comments.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
This commit is contained in:
Jeff Layton
2020-04-03 13:09:07 -04:00
committed by Ilya Dryomov
parent d67c72e6cc
commit 829ad4db95
4 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
fs/ceph/super.h
View File

@@ -362,8 +362,11 @@ struct ceph_inode_info {
struct list_head i_dirty_item;
/*
* Link to session's s_cap_flushing list. Protected by
* mdsc->cap_dirty_lock.
* Link to session's s_cap_flushing list. Protected in a similar
* fashion to i_dirty_item, but also by the s_mutex for changes. The
* s_cap_flushing list can be walked while holding either the s_mutex
* or msdc->cap_dirty_lock. List presence can also be checked while
* holding the i_ceph_lock for this inode.
*/
struct list_head i_flushing_item;