sched / idle: Call default_idle_call() from cpuidle_enter_state()
The check of the cpuidle_enter() return value against -EBUSY made in call_cpuidle() will not be necessary any more if cpuidle_enter_state() calls default_idle_call() directly when it is about to return -EBUSY, so make that happen and eliminate the check. Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Reviewed-by: Preeti U Murthy <preeti@linux.vnet.ibm.com> Tested-by: Preeti U Murthy <preeti@linux.vnet.ibm.com> Tested-by: Sudeep Holla <sudeep.holla@arm.com> Acked-by: Kevin Hilman <khilman@linaro.org>
This commit is contained in:
@@ -76,12 +76,13 @@ void __weak arch_cpu_idle(void)
|
||||
local_irq_enable();
|
||||
}
|
||||
|
||||
static void default_idle_call(void)
|
||||
/**
|
||||
* default_idle_call - Default CPU idle routine.
|
||||
*
|
||||
* To use when the cpuidle framework cannot be used.
|
||||
*/
|
||||
void default_idle_call(void)
|
||||
{
|
||||
/*
|
||||
* We can't use the cpuidle framework, let's use the default idle
|
||||
* routine.
|
||||
*/
|
||||
if (current_clr_polling_and_test())
|
||||
local_irq_enable();
|
||||
else
|
||||
@@ -91,8 +92,6 @@ static void default_idle_call(void)
|
||||
static int call_cpuidle(struct cpuidle_driver *drv, struct cpuidle_device *dev,
|
||||
int next_state)
|
||||
{
|
||||
int entered_state;
|
||||
|
||||
/* Fall back to the default arch idle method on errors. */
|
||||
if (next_state < 0) {
|
||||
default_idle_call();
|
||||
@@ -114,12 +113,7 @@ static int call_cpuidle(struct cpuidle_driver *drv, struct cpuidle_device *dev,
|
||||
* This function will block until an interrupt occurs and will take
|
||||
* care of re-enabling the local interrupts
|
||||
*/
|
||||
entered_state = cpuidle_enter(drv, dev, next_state);
|
||||
|
||||
if (entered_state == -EBUSY)
|
||||
default_idle_call();
|
||||
|
||||
return entered_state;
|
||||
return cpuidle_enter(drv, dev, next_state);
|
||||
}
|
||||
|
||||
/**
|
||||
|
Reference in New Issue
Block a user