spi: allow attaching device properties to SPI board info
Generic device properties support statically defined property sets. For them to be usable, we need to attach these property sets before devices are registered and probed. Allowing to attach property list to spi_board_info structure will allow non-ACPI non-DT boards switch to using generic properties and get rid of custom platform data. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:

committed by
Mark Brown

parent
c1ae3cfa0e
commit
826cf175ed
@@ -31,6 +31,7 @@
|
||||
#include <linux/of_gpio.h>
|
||||
#include <linux/pm_runtime.h>
|
||||
#include <linux/pm_domain.h>
|
||||
#include <linux/property.h>
|
||||
#include <linux/export.h>
|
||||
#include <linux/sched/rt.h>
|
||||
#include <uapi/linux/sched/types.h>
|
||||
@@ -600,13 +601,28 @@ struct spi_device *spi_new_device(struct spi_master *master,
|
||||
proxy->controller_data = chip->controller_data;
|
||||
proxy->controller_state = NULL;
|
||||
|
||||
status = spi_add_device(proxy);
|
||||
if (status < 0) {
|
||||
spi_dev_put(proxy);
|
||||
return NULL;
|
||||
if (chip->properties) {
|
||||
status = device_add_properties(&proxy->dev, chip->properties);
|
||||
if (status) {
|
||||
dev_err(&master->dev,
|
||||
"failed to add properties to '%s': %d\n",
|
||||
chip->modalias, status);
|
||||
goto err_dev_put;
|
||||
}
|
||||
}
|
||||
|
||||
status = spi_add_device(proxy);
|
||||
if (status < 0)
|
||||
goto err_remove_props;
|
||||
|
||||
return proxy;
|
||||
|
||||
err_remove_props:
|
||||
if (chip->properties)
|
||||
device_remove_properties(&proxy->dev);
|
||||
err_dev_put:
|
||||
spi_dev_put(proxy);
|
||||
return NULL;
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(spi_new_device);
|
||||
|
||||
@@ -664,6 +680,7 @@ static void spi_match_master_to_boardinfo(struct spi_master *master,
|
||||
*
|
||||
* The board info passed can safely be __initdata ... but be careful of
|
||||
* any embedded pointers (platform_data, etc), they're copied as-is.
|
||||
* Device properties are deep-copied though.
|
||||
*
|
||||
* Return: zero on success, else a negative error code.
|
||||
*/
|
||||
@@ -683,6 +700,13 @@ int spi_register_board_info(struct spi_board_info const *info, unsigned n)
|
||||
struct spi_master *master;
|
||||
|
||||
memcpy(&bi->board_info, info, sizeof(*info));
|
||||
if (info->properties) {
|
||||
bi->board_info.properties =
|
||||
property_entries_dup(info->properties);
|
||||
if (IS_ERR(bi->board_info.properties))
|
||||
return PTR_ERR(bi->board_info.properties);
|
||||
}
|
||||
|
||||
mutex_lock(&board_lock);
|
||||
list_add_tail(&bi->list, &board_list);
|
||||
list_for_each_entry(master, &spi_master_list, list)
|
||||
|
Reference in New Issue
Block a user