xfs: remove XFS_IOC_FSSETDM and XFS_IOC_FSSETDM_BY_HANDLE
Thes ioctls set DMAPI specific flags in the on-disk inode, but there is no way to actually ever query those flags. The only known user is xfsrestore with the -D option, which is documented to be only useful inside a DMAPI enviroment, which isn't supported by upstream XFS. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
This commit is contained in:

committed by
Darrick J. Wong

부모
eb0d21637f
커밋
8234532fd4
@@ -500,44 +500,6 @@ xfs_compat_attrmulti_by_handle(
|
||||
return error;
|
||||
}
|
||||
|
||||
STATIC int
|
||||
xfs_compat_fssetdm_by_handle(
|
||||
struct file *parfilp,
|
||||
void __user *arg)
|
||||
{
|
||||
int error;
|
||||
struct fsdmidata fsd;
|
||||
compat_xfs_fsop_setdm_handlereq_t dmhreq;
|
||||
struct dentry *dentry;
|
||||
|
||||
if (!capable(CAP_MKNOD))
|
||||
return -EPERM;
|
||||
if (copy_from_user(&dmhreq, arg,
|
||||
sizeof(compat_xfs_fsop_setdm_handlereq_t)))
|
||||
return -EFAULT;
|
||||
|
||||
dentry = xfs_compat_handlereq_to_dentry(parfilp, &dmhreq.hreq);
|
||||
if (IS_ERR(dentry))
|
||||
return PTR_ERR(dentry);
|
||||
|
||||
if (IS_IMMUTABLE(d_inode(dentry)) || IS_APPEND(d_inode(dentry))) {
|
||||
error = -EPERM;
|
||||
goto out;
|
||||
}
|
||||
|
||||
if (copy_from_user(&fsd, compat_ptr(dmhreq.data), sizeof(fsd))) {
|
||||
error = -EFAULT;
|
||||
goto out;
|
||||
}
|
||||
|
||||
error = xfs_set_dmattrs(XFS_I(d_inode(dentry)), fsd.fsd_dmevmask,
|
||||
fsd.fsd_dmstate);
|
||||
|
||||
out:
|
||||
dput(dentry);
|
||||
return error;
|
||||
}
|
||||
|
||||
long
|
||||
xfs_file_compat_ioctl(
|
||||
struct file *filp,
|
||||
@@ -646,8 +608,6 @@ xfs_file_compat_ioctl(
|
||||
return xfs_compat_attrlist_by_handle(filp, arg);
|
||||
case XFS_IOC_ATTRMULTI_BY_HANDLE_32:
|
||||
return xfs_compat_attrmulti_by_handle(filp, arg);
|
||||
case XFS_IOC_FSSETDM_BY_HANDLE_32:
|
||||
return xfs_compat_fssetdm_by_handle(filp, arg);
|
||||
default:
|
||||
/* try the native version */
|
||||
return xfs_file_ioctl(filp, cmd, (unsigned long)arg);
|
||||
|
Reference in New Issue
Block a user