ethtool: Clean up definitions of rule location arrays in RX NFC
Correct the description of ethtool_rxnfc::rule_locs; it is an array of currently used locations, not all possible valid locations. Add note that drivers must not use ethtool_rxnfc::rule_locs. The rule_locs argument to ethtool_ops::get_rxnfc is either NULL or a pointer to an array of u32, so change the parameter type accordingly. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
434495c50e
commit
815c7db5c8
@@ -1712,7 +1712,7 @@ static int gfar_set_nfc(struct net_device *dev, struct ethtool_rxnfc *cmd)
|
||||
}
|
||||
|
||||
static int gfar_get_nfc(struct net_device *dev, struct ethtool_rxnfc *cmd,
|
||||
void *rule_locs)
|
||||
u32 *rule_locs)
|
||||
{
|
||||
struct gfar_private *priv = netdev_priv(dev);
|
||||
int ret = 0;
|
||||
@@ -1728,7 +1728,7 @@ static int gfar_get_nfc(struct net_device *dev, struct ethtool_rxnfc *cmd,
|
||||
ret = gfar_get_cls(priv, cmd);
|
||||
break;
|
||||
case ETHTOOL_GRXCLSRLALL:
|
||||
ret = gfar_get_cls_all(priv, cmd, (u32 *) rule_locs);
|
||||
ret = gfar_get_cls_all(priv, cmd, rule_locs);
|
||||
break;
|
||||
default:
|
||||
ret = -EINVAL;
|
||||
|
Reference in New Issue
Block a user