powerpc/eeh: Cleanup list_head field names
Instances of struct eeh_pe are placed in a tree structure using the fields "child_list" and "child", so place these next to each other in the definition. The field "child" is a list entry, so remove the unnecessary and misleading use of the list initializer, LIST_HEAD(), on it. The eeh_dev struct contains two list entry fields, called "list" and "rmv_list". Rename them to "entry" and "rmv_entry" and, as above, stop initializing them with LIST_HEAD(). Signed-off-by: Sam Bobroff <sbobroff@linux.ibm.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
This commit is contained in:

committed by
Michael Ellerman

parent
bf773df9d1
commit
80e65b0094
@@ -98,13 +98,13 @@ struct eeh_pe {
|
||||
atomic_t pass_dev_cnt; /* Count of passed through devs */
|
||||
struct eeh_pe *parent; /* Parent PE */
|
||||
void *data; /* PE auxillary data */
|
||||
struct list_head child_list; /* Link PE to the child list */
|
||||
struct list_head edevs; /* Link list of EEH devices */
|
||||
struct list_head child; /* Child PEs */
|
||||
struct list_head child_list; /* List of PEs below this PE */
|
||||
struct list_head child; /* Memb. child_list/eeh_phb_pe */
|
||||
struct list_head edevs; /* List of eeh_dev in this PE */
|
||||
};
|
||||
|
||||
#define eeh_pe_for_each_dev(pe, edev, tmp) \
|
||||
list_for_each_entry_safe(edev, tmp, &pe->edevs, list)
|
||||
list_for_each_entry_safe(edev, tmp, &pe->edevs, entry)
|
||||
|
||||
#define eeh_for_each_pe(root, pe) \
|
||||
for (pe = root; pe; pe = eeh_pe_next(pe, root))
|
||||
@@ -141,8 +141,8 @@ struct eeh_dev {
|
||||
int aer_cap; /* Saved AER capability */
|
||||
int af_cap; /* Saved AF capability */
|
||||
struct eeh_pe *pe; /* Associated PE */
|
||||
struct list_head list; /* Form link list in the PE */
|
||||
struct list_head rmv_list; /* Record the removed edevs */
|
||||
struct list_head entry; /* Membership in eeh_pe.edevs */
|
||||
struct list_head rmv_entry; /* Membership in rmv_list */
|
||||
struct pci_dn *pdn; /* Associated PCI device node */
|
||||
struct pci_dev *pdev; /* Associated PCI device */
|
||||
bool in_error; /* Error flag for edev */
|
||||
|
Reference in New Issue
Block a user