xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ALSA: us122l: Use common error handling code in us122l_create_card()

Browse Source 
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Markus Elfring
2017-09-06 14:45:09 +02:00
committed by Takashi Iwai
parent e35e9ddfab
commit 80753cdfef
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
sound/usb/usx2y/us122l.c
View File

@@ -508,8 +508,7 @@ static bool us122l_create_card(struct snd_card *card)
err = us122l_create_usbmidi(card); err = us122l_create_usbmidi(card);
if (err < 0) { if (err < 0) {
snd_printk(KERN_ERR "us122l_create_usbmidi error %i \n", err); snd_printk(KERN_ERR "us122l_create_usbmidi error %i \n", err);
us122l_stop(us122l); goto stop;
return false;
} }
err = usb_stream_hwdep_new(card); err = usb_stream_hwdep_new(card);
if (err < 0) { if (err < 0) {
@@ -518,10 +517,13 @@ static bool us122l_create_card(struct snd_card *card)
list_for_each(p, &us122l->midi_list) list_for_each(p, &us122l->midi_list)
snd_usbmidi_disconnect(p); snd_usbmidi_disconnect(p);
us122l_stop(us122l); goto stop;
return false;
} }
return true; return true;
stop:
us122l_stop(us122l);
return false;
} }
static void snd_us122l_free(struct snd_card *card) static void snd_us122l_free(struct snd_card *card)