xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PCI: altera: Fix loop in tlp_read_packet()

Browse Source 
TLP_LOOP is 500 and the "loop" variable was a u8 so "loop < TLP_LOOP" is
always true.  We only need this condition to work if there is a problem so
it would have been easy to miss this in testing.

Make it a normal for loop with "int i" instead of over thinking things and
making it complicated.

Fixes: 6bb4dd154ae8 ("PCI: altera: Add Altera PCIe host controller driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Ley Foon Tan <lftan@altera.com>
This commit is contained in:
Dan Carpenter
2015-12-04 16:21:08 -06:00
committed by Bjorn Helgaas
parent 3845d2953a
commit 7f52f31443
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/pci/host/pcie-altera.c
View File

@@ -166,7 +166,7 @@ static bool altera_pcie_valid_config(struct altera_pcie *pcie,
static int tlp_read_packet(struct altera_pcie *pcie, u32 *value) static int tlp_read_packet(struct altera_pcie *pcie, u32 *value)
{ {
u8 loop; int i;
bool sop = 0; bool sop = 0;
u32 ctrl; u32 ctrl;
u32 reg0, reg1; u32 reg0, reg1;
@@ -175,7 +175,7 @@ static int tlp_read_packet(struct altera_pcie *pcie, u32 *value)
* Minimum 2 loops to read TLP headers and 1 loop to read data * Minimum 2 loops to read TLP headers and 1 loop to read data
* payload. * payload.
*/ */
for (loop = 0; loop < TLP_LOOP; loop++) { for (i = 0; i < TLP_LOOP; i++) {
ctrl = cra_readl(pcie, RP_RXCPL_STATUS); ctrl = cra_readl(pcie, RP_RXCPL_STATUS);
if ((ctrl & RP_RXCPL_SOP) || (ctrl & RP_RXCPL_EOP) || sop) { if ((ctrl & RP_RXCPL_SOP) || (ctrl & RP_RXCPL_EOP) || sop) {
reg0 = cra_readl(pcie, RP_RXCPL_REG0); reg0 = cra_readl(pcie, RP_RXCPL_REG0);