ACPI: maintain a single list of _HID and _CID IDs
There's no need to treat _HID and _CID differently. Keeping them in a single list makes code that uses the IDs a little simpler because it can just traverse the list rather than checking "do we have a HID?", "do we have any CIDs?" Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com> Reviewed-by: Alex Chiang <achiang@hp.com> Signed-off-by: Len Brown <len.brown@intel.com>
This commit is contained in:

zatwierdzone przez
Len Brown

rodzic
b1fbfb2ae8
commit
7f47fa6c2f
@@ -153,6 +153,7 @@ static int __init pnpacpi_add_device(struct acpi_device *device)
|
||||
acpi_handle temp = NULL;
|
||||
acpi_status status;
|
||||
struct pnp_dev *dev;
|
||||
struct acpi_hardware_id *id;
|
||||
|
||||
/*
|
||||
* If a PnPacpi device is not present , the device
|
||||
@@ -193,15 +194,12 @@ static int __init pnpacpi_add_device(struct acpi_device *device)
|
||||
if (dev->capabilities & PNP_CONFIGURABLE)
|
||||
pnpacpi_parse_resource_option_data(dev);
|
||||
|
||||
if (device->flags.compatible_ids) {
|
||||
struct acpica_device_id_list *cid_list = device->pnp.cid_list;
|
||||
int i;
|
||||
|
||||
for (i = 0; i < cid_list->count; i++) {
|
||||
if (!ispnpidacpi(cid_list->ids[i].string))
|
||||
continue;
|
||||
pnp_add_id(dev, cid_list->ids[i].string);
|
||||
}
|
||||
list_for_each_entry(id, &device->pnp.ids, list) {
|
||||
if (!strcmp(id->id, acpi_device_hid(device)))
|
||||
continue;
|
||||
if (!ispnpidacpi(id->id))
|
||||
continue;
|
||||
pnp_add_id(dev, id->id);
|
||||
}
|
||||
|
||||
/* clear out the damaged flags */
|
||||
|
Reference in New Issue
Block a user