USB: move many drivers to use DEVICE_ATTR_RO
Instead of "open coding" a DEVICE_ATTR() define, use the DEVICE_ATTR_RO() macro instead, which does everything properly instead. This does require a few static functions to be renamed to work properly, but thanks to a script from Joe Perches, this was easily done. Reported-by: Joe Perches <joe@perches.com> Cc: Matthieu CASTET <castet.matthieu@free.fr> Cc: Stanislaw Gruszka <stf_xl@wp.pl> Cc: Oliver Neukum <oneukum@suse.com> Acked-by: Alan Stern <stern@rowland.harvard.edu> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com> Acked-by: Pete Zaitcev <zaitcev@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
@@ -2315,7 +2315,7 @@ out:
|
||||
|
||||
static DEVICE_ATTR_RW(stat_status);
|
||||
|
||||
static ssize_t read_human_status(struct device *dev,
|
||||
static ssize_t stat_human_status_show(struct device *dev,
|
||||
struct device_attribute *attr, char *buf)
|
||||
{
|
||||
int ret = -ENODEV;
|
||||
@@ -2376,9 +2376,9 @@ out:
|
||||
return ret;
|
||||
}
|
||||
|
||||
static DEVICE_ATTR(stat_human_status, S_IRUGO, read_human_status, NULL);
|
||||
static DEVICE_ATTR_RO(stat_human_status);
|
||||
|
||||
static ssize_t read_delin(struct device *dev, struct device_attribute *attr,
|
||||
static ssize_t stat_delin_show(struct device *dev, struct device_attribute *attr,
|
||||
char *buf)
|
||||
{
|
||||
int ret = -ENODEV;
|
||||
@@ -2408,7 +2408,7 @@ out:
|
||||
return ret;
|
||||
}
|
||||
|
||||
static DEVICE_ATTR(stat_delin, S_IRUGO, read_delin, NULL);
|
||||
static DEVICE_ATTR_RO(stat_delin);
|
||||
|
||||
#define UEA_ATTR(name, reset) \
|
||||
\
|
||||
|
Reference in New Issue
Block a user