ocfs2: neaten do_error, ocfs2_error and ocfs2_abort
These uses sometimes do and sometimes don't have '\n' terminations. Make the uses consistently use '\n' terminations and remove the newline from the functions. Miscellanea: o Coalesce formats o Realign arguments Signed-off-by: Joe Perches <joe@perches.com> Reviewed-by: Mark Fasheh <mfasheh@suse.de> Cc: Joel Becker <jlbec@evilplan.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Šī revīzija ir iekļauta:

revīziju iesūtīja
Linus Torvalds

vecāks
d0c97d52f5
revīzija
7ecef14ab1
@@ -481,29 +481,25 @@ static int ocfs2_check_dir_trailer(struct inode *dir, struct buffer_head *bh)
|
||||
trailer = ocfs2_trailer_from_bh(bh, dir->i_sb);
|
||||
if (!OCFS2_IS_VALID_DIR_TRAILER(trailer)) {
|
||||
rc = ocfs2_error(dir->i_sb,
|
||||
"Invalid dirblock #%llu: "
|
||||
"signature = %.*s\n",
|
||||
(unsigned long long)bh->b_blocknr, 7,
|
||||
trailer->db_signature);
|
||||
"Invalid dirblock #%llu: signature = %.*s\n",
|
||||
(unsigned long long)bh->b_blocknr, 7,
|
||||
trailer->db_signature);
|
||||
goto out;
|
||||
}
|
||||
if (le64_to_cpu(trailer->db_blkno) != bh->b_blocknr) {
|
||||
rc = ocfs2_error(dir->i_sb,
|
||||
"Directory block #%llu has an invalid "
|
||||
"db_blkno of %llu",
|
||||
(unsigned long long)bh->b_blocknr,
|
||||
(unsigned long long)le64_to_cpu(trailer->db_blkno));
|
||||
"Directory block #%llu has an invalid db_blkno of %llu\n",
|
||||
(unsigned long long)bh->b_blocknr,
|
||||
(unsigned long long)le64_to_cpu(trailer->db_blkno));
|
||||
goto out;
|
||||
}
|
||||
if (le64_to_cpu(trailer->db_parent_dinode) !=
|
||||
OCFS2_I(dir)->ip_blkno) {
|
||||
rc = ocfs2_error(dir->i_sb,
|
||||
"Directory block #%llu on dinode "
|
||||
"#%llu has an invalid parent_dinode "
|
||||
"of %llu",
|
||||
(unsigned long long)bh->b_blocknr,
|
||||
(unsigned long long)OCFS2_I(dir)->ip_blkno,
|
||||
(unsigned long long)le64_to_cpu(trailer->db_blkno));
|
||||
"Directory block #%llu on dinode #%llu has an invalid parent_dinode of %llu\n",
|
||||
(unsigned long long)bh->b_blocknr,
|
||||
(unsigned long long)OCFS2_I(dir)->ip_blkno,
|
||||
(unsigned long long)le64_to_cpu(trailer->db_blkno));
|
||||
goto out;
|
||||
}
|
||||
out:
|
||||
@@ -602,9 +598,9 @@ static int ocfs2_validate_dx_root(struct super_block *sb,
|
||||
|
||||
if (!OCFS2_IS_VALID_DX_ROOT(dx_root)) {
|
||||
ret = ocfs2_error(sb,
|
||||
"Dir Index Root # %llu has bad signature %.*s",
|
||||
(unsigned long long)le64_to_cpu(dx_root->dr_blkno),
|
||||
7, dx_root->dr_signature);
|
||||
"Dir Index Root # %llu has bad signature %.*s\n",
|
||||
(unsigned long long)le64_to_cpu(dx_root->dr_blkno),
|
||||
7, dx_root->dr_signature);
|
||||
}
|
||||
|
||||
return ret;
|
||||
@@ -644,8 +640,8 @@ static int ocfs2_validate_dx_leaf(struct super_block *sb,
|
||||
}
|
||||
|
||||
if (!OCFS2_IS_VALID_DX_LEAF(dx_leaf)) {
|
||||
ret = ocfs2_error(sb, "Dir Index Leaf has bad signature %.*s",
|
||||
7, dx_leaf->dl_signature);
|
||||
ret = ocfs2_error(sb, "Dir Index Leaf has bad signature %.*s\n",
|
||||
7, dx_leaf->dl_signature);
|
||||
}
|
||||
|
||||
return ret;
|
||||
@@ -808,9 +804,9 @@ static int ocfs2_dx_dir_lookup_rec(struct inode *inode,
|
||||
|
||||
if (el->l_tree_depth) {
|
||||
ret = ocfs2_error(inode->i_sb,
|
||||
"Inode %lu has non zero tree depth in "
|
||||
"btree tree block %llu\n", inode->i_ino,
|
||||
(unsigned long long)eb_bh->b_blocknr);
|
||||
"Inode %lu has non zero tree depth in btree tree block %llu\n",
|
||||
inode->i_ino,
|
||||
(unsigned long long)eb_bh->b_blocknr);
|
||||
goto out;
|
||||
}
|
||||
}
|
||||
@@ -826,10 +822,11 @@ static int ocfs2_dx_dir_lookup_rec(struct inode *inode,
|
||||
}
|
||||
|
||||
if (!found) {
|
||||
ret = ocfs2_error(inode->i_sb, "Inode %lu has bad extent "
|
||||
"record (%u, %u, 0) in btree", inode->i_ino,
|
||||
le32_to_cpu(rec->e_cpos),
|
||||
ocfs2_rec_clusters(el, rec));
|
||||
ret = ocfs2_error(inode->i_sb,
|
||||
"Inode %lu has bad extent record (%u, %u, 0) in btree\n",
|
||||
inode->i_ino,
|
||||
le32_to_cpu(rec->e_cpos),
|
||||
ocfs2_rec_clusters(el, rec));
|
||||
goto out;
|
||||
}
|
||||
|
||||
|
Atsaukties uz šo jaunā problēmā
Block a user