[NETFILTER]: Fix logging regression
Loading one of the LOG target fails if a different target has already registered itself as backend for the same family. This can affect the ipt_LOG and ipt_ULOG modules when both are loaded. Reported and tested by: <t.artem@mailcity.com> Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
此提交包含在:
@@ -196,10 +196,8 @@ static int __init ebt_log_init(void)
|
||||
ret = ebt_register_watcher(&log);
|
||||
if (ret < 0)
|
||||
return ret;
|
||||
ret = nf_log_register(PF_BRIDGE, &ebt_log_logger);
|
||||
if (ret < 0 && ret != -EEXIST)
|
||||
ebt_unregister_watcher(&log);
|
||||
return ret;
|
||||
nf_log_register(PF_BRIDGE, &ebt_log_logger);
|
||||
return 0;
|
||||
}
|
||||
|
||||
static void __exit ebt_log_fini(void)
|
||||
|
@@ -308,12 +308,8 @@ static int __init ebt_ulog_init(void)
|
||||
else if ((ret = ebt_register_watcher(&ulog)))
|
||||
sock_release(ebtulognl->sk_socket);
|
||||
|
||||
if (nf_log_register(PF_BRIDGE, &ebt_ulog_logger) < 0) {
|
||||
printk(KERN_WARNING "ebt_ulog: not logging via ulog "
|
||||
"since somebody else already registered for PF_BRIDGE\n");
|
||||
/* we cannot make module load fail here, since otherwise
|
||||
* ebtables userspace would abort */
|
||||
}
|
||||
if (ret == 0)
|
||||
nf_log_register(PF_BRIDGE, &ebt_ulog_logger);
|
||||
|
||||
return ret;
|
||||
}
|
||||
|
新增問題並參考
封鎖使用者