percpu-refcount: use unsigned long for pcpu_count pointer
percpu_ref->pcpu_count is a percpu pointer with a status flag in its lowest bit. As such, it always goes through arithmetic operations which is very cumbersome to do on a pointer. It has to be first casted to unsigned long and then back. Let's just make the field unsigned long so that we can skip the first casts. While at it, rename it to pcpu_counter_ptr to clarify that it's a pointer value. Signed-off-by: Tejun Heo <tj@kernel.org> Cc: Kent Overstreet <kmo@daterainc.com> Cc: Christoph Lameter <cl@linux-foundation.org>
This commit is contained in:
@@ -61,7 +61,7 @@ struct percpu_ref {
|
||||
* hack because we need to keep the pointer around for
|
||||
* percpu_ref_kill_rcu())
|
||||
*/
|
||||
unsigned __percpu *pcpu_count;
|
||||
unsigned long pcpu_count_ptr;
|
||||
percpu_ref_func_t *release;
|
||||
percpu_ref_func_t *confirm_kill;
|
||||
struct rcu_head rcu;
|
||||
@@ -99,7 +99,7 @@ static inline void percpu_ref_kill(struct percpu_ref *ref)
|
||||
static inline bool __pcpu_ref_alive(struct percpu_ref *ref,
|
||||
unsigned __percpu **pcpu_countp)
|
||||
{
|
||||
unsigned long pcpu_ptr = (unsigned long)ACCESS_ONCE(ref->pcpu_count);
|
||||
unsigned long pcpu_ptr = ACCESS_ONCE(ref->pcpu_count_ptr);
|
||||
|
||||
if (unlikely(pcpu_ptr & PCPU_REF_DEAD))
|
||||
return false;
|
||||
|
Reference in New Issue
Block a user