drm/vkms: Fix plane duplicate_state
We need to handle allocation failures and bail out. While at it, tune the allocation failures down to debug level. syzbot injected an allocation failure and then hit this WARN_ON. Reported-by: syzbot+eb6e5365f23c02517dda@syzkaller.appspotmail.com Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Haneen Mohammed <hamohammed.sa@gmail.com> Cc: Sean Paul <seanpaul@chromium.org> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> Cc: Gustavo Padovan <gustavo.padovan@collabora.com> Reviewed-by: Eric Anholt <eric@anholt.net> Link: https://patchwork.freedesktop.org/patch/msgid/20181128101033.4840-1-daniel.vetter@ffwll.ch
此提交包含在:
@@ -23,8 +23,11 @@ vkms_plane_duplicate_state(struct drm_plane *plane)
|
||||
return NULL;
|
||||
|
||||
crc_data = kzalloc(sizeof(*crc_data), GFP_KERNEL);
|
||||
if (WARN_ON(!crc_data))
|
||||
DRM_INFO("Couldn't allocate crc_data");
|
||||
if (!crc_data) {
|
||||
DRM_DEBUG_KMS("Couldn't allocate crc_data\n");
|
||||
kfree(vkms_state);
|
||||
return NULL;
|
||||
}
|
||||
|
||||
vkms_state->crc_data = crc_data;
|
||||
|
||||
|
新增問題並參考
封鎖使用者