xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/msm/hdmi: fix error check return value of irq_of_parse_and_map()

Browse Source 
[ Upstream commit 03371e4fbdeb7f596cbceacb59e474248b6d95ac ]

The irq_of_parse_and_map() function returns 0 on failure, and does not
return a negative value anyhow, so never enter this conditional branch.

Fixes: f6a8eaca0e ("drm/msm/mdp5: use irqdomains")
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Patchwork: https://patchwork.freedesktop.org/patch/483294/
Link: https://lore.kernel.org/r/20220425091831.3500487-1-lv.ruyi@zte.com.cn
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Lv Ruyi
2022-04-25 09:18:31 +00:00
committed by Greg Kroah-Hartman
parent d9cb951d11
commit 7b815e91ff
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/gpu/drm/msm/hdmi/hdmi.c
View File

@@ -315,9 +315,9 @@ int msm_hdmi_modeset_init(struct hdmi *hdmi,
} }
hdmi->irq = irq_of_parse_and_map(pdev->dev.of_node, 0); hdmi->irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
if (hdmi->irq < 0) { if (!hdmi->irq) {
ret = hdmi->irq; ret = -EINVAL;
DRM_DEV_ERROR(dev->dev, "failed to get irq: %d\n", ret); DRM_DEV_ERROR(dev->dev, "failed to get irq\n");
goto fail; goto fail;
} }