caif: Remove OOM messages, use kzalloc
Remove per site OOM messages because they duplicate the generic mm subsystem OOM message. Use kzalloc instead of kmalloc/memset when next to the OOM message removals. Reduces object size (allyesconfig ~2%) $ size -t drivers/net/caif/built-in.o.old net/caif/built-in.o.old text data bss dec hex filename 32297 700 8224 41221 a105 drivers/net/caif/built-in.o.old 72159 1317 20552 94028 16f4c net/caif/built-in.o.old 104456 2017 28776 135249 21051 (TOTALS) $ size -t drivers/net/caif/built-in.o.new net/caif/built-in.o.new text data bss dec hex filename 31975 700 8184 40859 9f9b drivers/net/caif/built-in.o.new 70748 1317 20152 92217 16839 net/caif/built-in.o.new 102723 2017 28336 133076 207d4 (TOTALS) Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
343e43c028
commit
7ac2ed0cee
@@ -937,11 +937,8 @@ int cfhsi_probe(struct platform_device *pdev)
|
||||
int res;
|
||||
|
||||
ndev = alloc_netdev(sizeof(struct cfhsi), "cfhsi%d", cfhsi_setup);
|
||||
if (!ndev) {
|
||||
dev_err(&pdev->dev, "%s: alloc_netdev failed.\n",
|
||||
__func__);
|
||||
if (!ndev)
|
||||
return -ENODEV;
|
||||
}
|
||||
|
||||
cfhsi = netdev_priv(ndev);
|
||||
cfhsi->ndev = ndev;
|
||||
@@ -969,8 +966,6 @@ int cfhsi_probe(struct platform_device *pdev)
|
||||
*/
|
||||
cfhsi->tx_buf = kzalloc(CFHSI_BUF_SZ_TX, GFP_KERNEL);
|
||||
if (!cfhsi->tx_buf) {
|
||||
dev_err(&ndev->dev, "%s: Failed to allocate TX buffer.\n",
|
||||
__func__);
|
||||
res = -ENODEV;
|
||||
goto err_alloc_tx;
|
||||
}
|
||||
@@ -981,8 +976,6 @@ int cfhsi_probe(struct platform_device *pdev)
|
||||
*/
|
||||
cfhsi->rx_buf = kzalloc(CFHSI_BUF_SZ_RX, GFP_KERNEL);
|
||||
if (!cfhsi->rx_buf) {
|
||||
dev_err(&ndev->dev, "%s: Failed to allocate RX buffer.\n",
|
||||
__func__);
|
||||
res = -ENODEV;
|
||||
goto err_alloc_rx;
|
||||
}
|
||||
|
Reference in New Issue
Block a user