Merge tag 'linux-can-next-for-4.16-20180105' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next
Marc Kleine-Budde says: ==================== pull-request: can-next 2017-12-01,Re: pull-request: can-next this is a pull request of 7 patches for net-next/master. All patches are by me. Patch 6 is for the "can_raw" protocol and add error checking to the bind() function. All other patches clean up the coding style and remove unused parameters in various CAN drivers and infrastructure. ==================== Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
@@ -256,7 +256,7 @@ int can_rx_offload_add_timestamp(struct net_device *dev, struct can_rx_offload *
|
||||
weight = offload->mb_first - offload->mb_last;
|
||||
}
|
||||
|
||||
return can_rx_offload_init_queue(dev, offload, weight);;
|
||||
return can_rx_offload_init_queue(dev, offload, weight);
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(can_rx_offload_add_timestamp);
|
||||
|
||||
|
@@ -508,7 +508,7 @@ static void slc_sync(void)
|
||||
}
|
||||
|
||||
/* Find a free SLCAN channel, and link in this `tty' line. */
|
||||
static struct slcan *slc_alloc(dev_t line)
|
||||
static struct slcan *slc_alloc(void)
|
||||
{
|
||||
int i;
|
||||
char name[IFNAMSIZ];
|
||||
@@ -583,7 +583,7 @@ static int slcan_open(struct tty_struct *tty)
|
||||
|
||||
/* OK. Find a free SLCAN channel to use. */
|
||||
err = -ENFILE;
|
||||
sl = slc_alloc(tty_devnum(tty));
|
||||
sl = slc_alloc();
|
||||
if (sl == NULL)
|
||||
goto err_exit;
|
||||
|
||||
|
@@ -612,8 +612,7 @@ static int mcp251x_do_set_bittiming(struct net_device *net)
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int mcp251x_setup(struct net_device *net, struct mcp251x_priv *priv,
|
||||
struct spi_device *spi)
|
||||
static int mcp251x_setup(struct net_device *net, struct spi_device *spi)
|
||||
{
|
||||
mcp251x_do_set_bittiming(net);
|
||||
|
||||
@@ -775,7 +774,7 @@ static void mcp251x_restart_work_handler(struct work_struct *ws)
|
||||
mutex_lock(&priv->mcp_lock);
|
||||
if (priv->after_suspend) {
|
||||
mcp251x_hw_reset(spi);
|
||||
mcp251x_setup(net, priv, spi);
|
||||
mcp251x_setup(net, spi);
|
||||
if (priv->after_suspend & AFTER_SUSPEND_RESTART) {
|
||||
mcp251x_set_normal_mode(spi);
|
||||
} else if (priv->after_suspend & AFTER_SUSPEND_UP) {
|
||||
@@ -971,7 +970,7 @@ static int mcp251x_open(struct net_device *net)
|
||||
mcp251x_open_clean(net);
|
||||
goto open_unlock;
|
||||
}
|
||||
ret = mcp251x_setup(net, priv, spi);
|
||||
ret = mcp251x_setup(net, spi);
|
||||
if (ret) {
|
||||
mcp251x_open_clean(net);
|
||||
goto open_unlock;
|
||||
|
@@ -243,7 +243,7 @@ static struct gs_tx_context *gs_get_tx_context(struct gs_can *dev,
|
||||
return NULL;
|
||||
}
|
||||
|
||||
static int gs_cmd_reset(struct gs_usb *gsusb, struct gs_can *gsdev)
|
||||
static int gs_cmd_reset(struct gs_can *gsdev)
|
||||
{
|
||||
struct gs_device_mode *dm;
|
||||
struct usb_interface *intf = gsdev->iface;
|
||||
@@ -709,7 +709,7 @@ static int gs_can_close(struct net_device *netdev)
|
||||
atomic_set(&dev->active_tx_urbs, 0);
|
||||
|
||||
/* reset the device */
|
||||
rc = gs_cmd_reset(parent, dev);
|
||||
rc = gs_cmd_reset(dev);
|
||||
if (rc < 0)
|
||||
netdev_warn(netdev, "Couldn't shutdown device (err=%d)", rc);
|
||||
|
||||
|
@@ -158,7 +158,7 @@ void peak_usb_get_ts_time(struct peak_time_ref *time_ref, u32 ts, ktime_t *time)
|
||||
* post received skb after having set any hw timestamp
|
||||
*/
|
||||
int peak_usb_netif_rx(struct sk_buff *skb,
|
||||
struct peak_time_ref *time_ref, u32 ts_low, u32 ts_high)
|
||||
struct peak_time_ref *time_ref, u32 ts_low)
|
||||
{
|
||||
struct skb_shared_hwtstamps *hwts = skb_hwtstamps(skb);
|
||||
|
||||
|
@@ -153,7 +153,7 @@ void peak_usb_update_ts_now(struct peak_time_ref *time_ref, u32 ts_now);
|
||||
void peak_usb_set_ts_now(struct peak_time_ref *time_ref, u32 ts_now);
|
||||
void peak_usb_get_ts_time(struct peak_time_ref *time_ref, u32 ts, ktime_t *tv);
|
||||
int peak_usb_netif_rx(struct sk_buff *skb,
|
||||
struct peak_time_ref *time_ref, u32 ts_low, u32 ts_high);
|
||||
struct peak_time_ref *time_ref, u32 ts_low);
|
||||
void peak_usb_async_complete(struct urb *urb);
|
||||
void peak_usb_restart_complete(struct peak_usb_device *dev);
|
||||
|
||||
|
@@ -513,8 +513,7 @@ static int pcan_usb_fd_decode_canmsg(struct pcan_usb_fd_if *usb_if,
|
||||
else
|
||||
memcpy(cfd->data, rm->d, cfd->len);
|
||||
|
||||
peak_usb_netif_rx(skb, &usb_if->time_ref,
|
||||
le32_to_cpu(rm->ts_low), le32_to_cpu(rm->ts_high));
|
||||
peak_usb_netif_rx(skb, &usb_if->time_ref, le32_to_cpu(rm->ts_low));
|
||||
|
||||
netdev->stats.rx_packets++;
|
||||
netdev->stats.rx_bytes += cfd->len;
|
||||
@@ -574,8 +573,7 @@ static int pcan_usb_fd_decode_status(struct pcan_usb_fd_if *usb_if,
|
||||
if (!skb)
|
||||
return -ENOMEM;
|
||||
|
||||
peak_usb_netif_rx(skb, &usb_if->time_ref,
|
||||
le32_to_cpu(sm->ts_low), le32_to_cpu(sm->ts_high));
|
||||
peak_usb_netif_rx(skb, &usb_if->time_ref, le32_to_cpu(sm->ts_low));
|
||||
|
||||
netdev->stats.rx_packets++;
|
||||
netdev->stats.rx_bytes += cf->can_dlc;
|
||||
@@ -617,8 +615,7 @@ static int pcan_usb_fd_decode_overrun(struct pcan_usb_fd_if *usb_if,
|
||||
cf->can_id |= CAN_ERR_CRTL;
|
||||
cf->data[1] |= CAN_ERR_CRTL_RX_OVERFLOW;
|
||||
|
||||
peak_usb_netif_rx(skb, &usb_if->time_ref,
|
||||
le32_to_cpu(ov->ts_low), le32_to_cpu(ov->ts_high));
|
||||
peak_usb_netif_rx(skb, &usb_if->time_ref, le32_to_cpu(ov->ts_low));
|
||||
|
||||
netdev->stats.rx_over_errors++;
|
||||
netdev->stats.rx_errors++;
|
||||
|
Reference in New Issue
Block a user