net: use helpers to change sk_ack_backlog
Writers are holding a lock, but many readers do not. Following patch will add appropriate barriers in sk_acceptq_removed() and sk_acceptq_added(). Signed-off-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
25c7a6d1f9
commit
7976a11b30
@@ -324,7 +324,7 @@ void sctp_association_free(struct sctp_association *asoc)
|
||||
* socket.
|
||||
*/
|
||||
if (sctp_style(sk, TCP) && sctp_sstate(sk, LISTENING))
|
||||
sk->sk_ack_backlog--;
|
||||
sk_acceptq_removed(sk);
|
||||
}
|
||||
|
||||
/* Mark as dead, so other users can know this structure is
|
||||
@@ -1073,7 +1073,7 @@ void sctp_assoc_migrate(struct sctp_association *assoc, struct sock *newsk)
|
||||
|
||||
/* Decrement the backlog value for a TCP-style socket. */
|
||||
if (sctp_style(oldsk, TCP))
|
||||
oldsk->sk_ack_backlog--;
|
||||
sk_acceptq_removed(oldsk);
|
||||
|
||||
/* Release references to the old endpoint and the sock. */
|
||||
sctp_endpoint_put(assoc->ep);
|
||||
|
Reference in New Issue
Block a user