cxl: Fixes for Coherent Accelerator Interface Architecture 2.0
A previous set of patches "cxl: Add support for Coherent Accelerator
Interface Architecture 2.0" has introduced a new support for the CAPI
cards. These patches have been tested on Simulation environment and
quite a bit of them have been tested on real hardware.
This patch brings new fixes after a series of tests carried out on new
equipment:
- Add POWER9 definition.
- Re-enable any masked interrupts when the AFU is not activated
after resetting the AFU.
- Remove the api cxl_is_psl8/9 which is no longer useful.
- Do not dump CAPI1 registers.
- Rewrite cxl_is_page_fault() function.
- Do not register slb callack on P9.
Fixes: f24be42aab
("cxl: Add psl9 specific code")
Signed-off-by: Christophe Lombard <clombard@linux.vnet.ibm.com>
Acked-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
This commit is contained in:

committed by
Michael Ellerman

parent
34f19ff1b5
commit
797625deae
@@ -105,11 +105,16 @@ static int native_afu_reset(struct cxl_afu *afu)
|
||||
CXL_AFU_Cntl_An_RS_MASK | CXL_AFU_Cntl_An_ES_MASK,
|
||||
false);
|
||||
|
||||
/* Re-enable any masked interrupts */
|
||||
serr = cxl_p1n_read(afu, CXL_PSL_SERR_An);
|
||||
serr &= ~CXL_PSL_SERR_An_IRQ_MASKS;
|
||||
cxl_p1n_write(afu, CXL_PSL_SERR_An, serr);
|
||||
|
||||
/*
|
||||
* Re-enable any masked interrupts when the AFU is not
|
||||
* activated to avoid side effects after attaching a process
|
||||
* in dedicated mode.
|
||||
*/
|
||||
if (afu->current_mode == 0) {
|
||||
serr = cxl_p1n_read(afu, CXL_PSL_SERR_An);
|
||||
serr &= ~CXL_PSL_SERR_An_IRQ_MASKS;
|
||||
cxl_p1n_write(afu, CXL_PSL_SERR_An, serr);
|
||||
}
|
||||
|
||||
return rc;
|
||||
}
|
||||
@@ -139,9 +144,9 @@ int cxl_psl_purge(struct cxl_afu *afu)
|
||||
|
||||
pr_devel("PSL purge request\n");
|
||||
|
||||
if (cxl_is_psl8(afu))
|
||||
if (cxl_is_power8())
|
||||
trans_fault = CXL_PSL_DSISR_TRANS;
|
||||
if (cxl_is_psl9(afu))
|
||||
if (cxl_is_power9())
|
||||
trans_fault = CXL_PSL9_DSISR_An_TF;
|
||||
|
||||
if (!cxl_ops->link_ok(afu->adapter, afu)) {
|
||||
@@ -603,7 +608,7 @@ static u64 calculate_sr(struct cxl_context *ctx)
|
||||
if (!test_tsk_thread_flag(current, TIF_32BIT))
|
||||
sr |= CXL_PSL_SR_An_SF;
|
||||
}
|
||||
if (cxl_is_psl9(ctx->afu)) {
|
||||
if (cxl_is_power9()) {
|
||||
if (radix_enabled())
|
||||
sr |= CXL_PSL_SR_An_XLAT_ror;
|
||||
else
|
||||
@@ -1117,10 +1122,10 @@ static irqreturn_t native_handle_psl_slice_error(struct cxl_context *ctx,
|
||||
|
||||
static bool cxl_is_translation_fault(struct cxl_afu *afu, u64 dsisr)
|
||||
{
|
||||
if ((cxl_is_psl8(afu)) && (dsisr & CXL_PSL_DSISR_TRANS))
|
||||
if ((cxl_is_power8()) && (dsisr & CXL_PSL_DSISR_TRANS))
|
||||
return true;
|
||||
|
||||
if ((cxl_is_psl9(afu)) && (dsisr & CXL_PSL9_DSISR_An_TF))
|
||||
if ((cxl_is_power9()) && (dsisr & CXL_PSL9_DSISR_An_TF))
|
||||
return true;
|
||||
|
||||
return false;
|
||||
@@ -1194,10 +1199,10 @@ static void native_irq_wait(struct cxl_context *ctx)
|
||||
if (ph != ctx->pe)
|
||||
return;
|
||||
dsisr = cxl_p2n_read(ctx->afu, CXL_PSL_DSISR_An);
|
||||
if (cxl_is_psl8(ctx->afu) &&
|
||||
if (cxl_is_power8() &&
|
||||
((dsisr & CXL_PSL_DSISR_PENDING) == 0))
|
||||
return;
|
||||
if (cxl_is_psl9(ctx->afu) &&
|
||||
if (cxl_is_power9() &&
|
||||
((dsisr & CXL_PSL9_DSISR_PENDING) == 0))
|
||||
return;
|
||||
/*
|
||||
|
Reference in New Issue
Block a user