xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[SCSI] libfc: change interface for rport_create

Browse Source 
The interface for lport->tt.rport_create() takes a fc_disc_port arg,
which is unnatural for most calls.   The only reason for this was
to avoid passing in the local port as an argument, but otherwise
added to complexity.

Simplify by just using lport and fc_rport_identifiers.

Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
This commit is contained in:
Joe Eykholt
2009-08-25 14:00:39 -07:00
committed by James Bottomley
parent ab28f1fd3b
commit 795d86f55e
4 changed files with 34 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
drivers/scsi/libfc/fc_lport.c
View File

@@ -211,20 +211,19 @@ static void fc_lport_ptp_setup(struct fc_lport *lport,
u32 remote_fid, u64 remote_wwpn,
u64 remote_wwnn)
{
struct fc_disc_port dp;
struct fc_rport_identifiers ids;
dp.lp = lport;
dp.ids.port_id = remote_fid;
dp.ids.port_name = remote_wwpn;
dp.ids.node_name = remote_wwnn;
dp.ids.roles = FC_RPORT_ROLE_UNKNOWN;
ids.port_id = remote_fid;
ids.port_name = remote_wwpn;
ids.node_name = remote_wwnn;
ids.roles = FC_RPORT_ROLE_UNKNOWN;
if (lport->ptp_rp) {
lport->tt.rport_logoff(lport->ptp_rp);
lport->ptp_rp = NULL;
}
lport->ptp_rp = lport->tt.rport_create(&dp);
lport->ptp_rp = lport->tt.rport_create(lport, &ids);
lport->tt.rport_login(lport->ptp_rp);
@@ -1307,20 +1306,19 @@ static void fc_lport_enter_dns(struct fc_lport *lport)
{
struct fc_rport *rport;
struct fc_rport_priv *rdata;
struct fc_disc_port dp;
struct fc_rport_identifiers ids;
dp.ids.port_id = FC_FID_DIR_SERV;
dp.ids.port_name = -1;
dp.ids.node_name = -1;
dp.ids.roles = FC_RPORT_ROLE_UNKNOWN;
dp.lp = lport;
ids.port_id = FC_FID_DIR_SERV;
ids.port_name = -1;
ids.node_name = -1;
ids.roles = FC_RPORT_ROLE_UNKNOWN;
FC_LPORT_DBG(lport, "Entered DNS state from %s state\n",
fc_lport_state(lport));
fc_lport_state_enter(lport, LPORT_ST_DNS);
rport = lport->tt.rport_create(&dp);
rport = lport->tt.rport_create(lport, &ids);
if (!rport)
goto err;