xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

IB/uverbs: Allow RDMA_REMOVE_DESTROY to work concurrently with disassociate

Browse Source 
After all the recent structural changes this is now straightfoward, hoist
the hw_destroy_rwsem up out of rdma_destroy_explicit and wrap it around
the uobject write lock as well as the destroy.

This is necessary as obtaining a write lock concurrently with
uverbs_destroy_ufile_hw() will cause malfunction.

After this change none of the destroy callbacks require the
disassociate_srcu lock to be correct.

This requires introducing a new lookup mode, UVERBS_LOOKUP_DESTROY as the
IOCTL interface needs to hold an unlocked kref until all command
verification is completed.

Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
This commit is contained in:
Jason Gunthorpe
2018-07-25 21:40:14 -06:00
parent 9867f5c669
commit 7452a3c745
4 changed files with 63 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
include/rdma/uverbs_types.h
View File

@@ -41,6 +41,12 @@ struct uverbs_obj_type;
enum rdma_lookup_mode {
UVERBS_LOOKUP_READ,
UVERBS_LOOKUP_WRITE,
/*
* Destroy is like LOOKUP_WRITE, except that the uobject is not
* locked. uobj_destroy is used to convert a LOOKUP_DESTROY lock into
* a LOOKUP_WRITE lock.
*/
UVERBS_LOOKUP_DESTROY,
};
/*
@@ -129,7 +135,6 @@ struct ib_uobject *rdma_alloc_begin_uobject(const struct uverbs_obj_type *type,
struct ib_uverbs_file *ufile);
void rdma_alloc_abort_uobject(struct ib_uobject *uobj);
int __must_check rdma_alloc_commit_uobject(struct ib_uobject *uobj);
int rdma_explicit_destroy(struct ib_uobject *uobject);
struct uverbs_obj_fd_type {
/*