perf report: Show progress bar for output resorting
Sometimes it takes a long time to resort hist entries for output in case of a large data file. Show a progress bar window and inform user. Signed-off-by: Namhyung Kim <namhyung@kernel.org> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: David Ahern <dsahern@gmail.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Stephane Eranian <eranian@google.com> Link: http://lkml.kernel.org/r/1419223455-4362-3-git-send-email-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:

committed by
Arnaldo Carvalho de Melo

parent
ac931f87a6
commit
740b97f950
@@ -457,6 +457,19 @@ static void report__collapse_hists(struct report *rep)
|
||||
ui_progress__finish();
|
||||
}
|
||||
|
||||
static void report__output_resort(struct report *rep)
|
||||
{
|
||||
struct ui_progress prog;
|
||||
struct perf_evsel *pos;
|
||||
|
||||
ui_progress__init(&prog, rep->nr_entries, "Sorting events for output...");
|
||||
|
||||
evlist__for_each(rep->session->evlist, pos)
|
||||
hists__output_resort(evsel__hists(pos), &prog);
|
||||
|
||||
ui_progress__finish();
|
||||
}
|
||||
|
||||
static int __cmd_report(struct report *rep)
|
||||
{
|
||||
int ret;
|
||||
@@ -505,13 +518,20 @@ static int __cmd_report(struct report *rep)
|
||||
if (session_done())
|
||||
return 0;
|
||||
|
||||
/*
|
||||
* recalculate number of entries after collapsing since it
|
||||
* might be changed during the collapse phase.
|
||||
*/
|
||||
rep->nr_entries = 0;
|
||||
evlist__for_each(session->evlist, pos)
|
||||
rep->nr_entries += evsel__hists(pos)->nr_entries;
|
||||
|
||||
if (rep->nr_entries == 0) {
|
||||
ui__error("The %s file has no samples!\n", file->path);
|
||||
return 0;
|
||||
}
|
||||
|
||||
evlist__for_each(session->evlist, pos)
|
||||
hists__output_resort(evsel__hists(pos));
|
||||
report__output_resort(rep);
|
||||
|
||||
return report__browse_hists(rep);
|
||||
}
|
||||
|
Reference in New Issue
Block a user