cpu/hotplug: Cleanup state names
When the state names got added a script was used to add the extra argument to the calls. The script basically converted the state constant to a string, but the cleanup to convert these strings into meaningful ones did not happen. Replace all the useless strings with 'subsys/xxx/yyy:state' strings which are used in all the other places already. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Sebastian Siewior <bigeasy@linutronix.de> Link: http://lkml.kernel.org/r/20161221192112.085444152@linutronix.de Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cette révision appartient à :
@@ -371,7 +371,7 @@ static int __init init_vdso(void)
|
||||
|
||||
/* notifier priority > KVM */
|
||||
return cpuhp_setup_state(CPUHP_AP_X86_VDSO_VMA_ONLINE,
|
||||
"AP_X86_VDSO_VMA_ONLINE", vgetcpu_online, NULL);
|
||||
"x86/vdso/vma:online", vgetcpu_online, NULL);
|
||||
}
|
||||
subsys_initcall(init_vdso);
|
||||
#endif /* CONFIG_X86_64 */
|
||||
|
@@ -1010,7 +1010,7 @@ static __init int amd_ibs_init(void)
|
||||
* all online cpus.
|
||||
*/
|
||||
cpuhp_setup_state(CPUHP_AP_PERF_X86_AMD_IBS_STARTING,
|
||||
"AP_PERF_X86_AMD_IBS_STARTING",
|
||||
"perf/x86/amd/ibs:STARTING",
|
||||
x86_pmu_amd_ibs_starting_cpu,
|
||||
x86_pmu_amd_ibs_dying_cpu);
|
||||
|
||||
|
@@ -291,7 +291,7 @@ static int __init amd_power_pmu_init(void)
|
||||
|
||||
|
||||
cpuhp_setup_state(CPUHP_AP_PERF_X86_AMD_POWER_ONLINE,
|
||||
"AP_PERF_X86_AMD_POWER_ONLINE",
|
||||
"perf/x86/amd/power:online",
|
||||
power_cpu_init, power_cpu_exit);
|
||||
|
||||
ret = perf_pmu_register(&pmu_class, "power", -1);
|
||||
|
@@ -527,16 +527,16 @@ static int __init amd_uncore_init(void)
|
||||
* Install callbacks. Core will call them for each online cpu.
|
||||
*/
|
||||
if (cpuhp_setup_state(CPUHP_PERF_X86_AMD_UNCORE_PREP,
|
||||
"PERF_X86_AMD_UNCORE_PREP",
|
||||
"perf/x86/amd/uncore:prepare",
|
||||
amd_uncore_cpu_up_prepare, amd_uncore_cpu_dead))
|
||||
goto fail_l2;
|
||||
|
||||
if (cpuhp_setup_state(CPUHP_AP_PERF_X86_AMD_UNCORE_STARTING,
|
||||
"AP_PERF_X86_AMD_UNCORE_STARTING",
|
||||
"perf/x86/amd/uncore:starting",
|
||||
amd_uncore_cpu_starting, NULL))
|
||||
goto fail_prep;
|
||||
if (cpuhp_setup_state(CPUHP_AP_PERF_X86_AMD_UNCORE_ONLINE,
|
||||
"AP_PERF_X86_AMD_UNCORE_ONLINE",
|
||||
"perf/x86/amd/uncore:online",
|
||||
amd_uncore_cpu_online,
|
||||
amd_uncore_cpu_down_prepare))
|
||||
goto fail_start;
|
||||
|
@@ -1820,18 +1820,18 @@ static int __init init_hw_perf_events(void)
|
||||
* Install callbacks. Core will call them for each online
|
||||
* cpu.
|
||||
*/
|
||||
err = cpuhp_setup_state(CPUHP_PERF_X86_PREPARE, "PERF_X86_PREPARE",
|
||||
err = cpuhp_setup_state(CPUHP_PERF_X86_PREPARE, "perf/x86:prepare",
|
||||
x86_pmu_prepare_cpu, x86_pmu_dead_cpu);
|
||||
if (err)
|
||||
return err;
|
||||
|
||||
err = cpuhp_setup_state(CPUHP_AP_PERF_X86_STARTING,
|
||||
"AP_PERF_X86_STARTING", x86_pmu_starting_cpu,
|
||||
"perf/x86:starting", x86_pmu_starting_cpu,
|
||||
x86_pmu_dying_cpu);
|
||||
if (err)
|
||||
goto out;
|
||||
|
||||
err = cpuhp_setup_state(CPUHP_AP_PERF_X86_ONLINE, "AP_PERF_X86_ONLINE",
|
||||
err = cpuhp_setup_state(CPUHP_AP_PERF_X86_ONLINE, "perf/x86:online",
|
||||
x86_pmu_online_cpu, NULL);
|
||||
if (err)
|
||||
goto out1;
|
||||
|
@@ -1747,9 +1747,9 @@ static int __init intel_cqm_init(void)
|
||||
* is enabled to avoid notifier leak.
|
||||
*/
|
||||
cpuhp_setup_state(CPUHP_AP_PERF_X86_CQM_STARTING,
|
||||
"AP_PERF_X86_CQM_STARTING",
|
||||
"perf/x86/cqm:starting",
|
||||
intel_cqm_cpu_starting, NULL);
|
||||
cpuhp_setup_state(CPUHP_AP_PERF_X86_CQM_ONLINE, "AP_PERF_X86_CQM_ONLINE",
|
||||
cpuhp_setup_state(CPUHP_AP_PERF_X86_CQM_ONLINE, "perf/x86/cqm:online",
|
||||
NULL, intel_cqm_cpu_exit);
|
||||
|
||||
out:
|
||||
|
@@ -803,13 +803,13 @@ static int __init rapl_pmu_init(void)
|
||||
* Install callbacks. Core will call them for each online cpu.
|
||||
*/
|
||||
|
||||
ret = cpuhp_setup_state(CPUHP_PERF_X86_RAPL_PREP, "PERF_X86_RAPL_PREP",
|
||||
ret = cpuhp_setup_state(CPUHP_PERF_X86_RAPL_PREP, "perf/x86/rapl:prepare",
|
||||
rapl_cpu_prepare, NULL);
|
||||
if (ret)
|
||||
goto out;
|
||||
|
||||
ret = cpuhp_setup_state(CPUHP_AP_PERF_X86_RAPL_ONLINE,
|
||||
"AP_PERF_X86_RAPL_ONLINE",
|
||||
"perf/x86/rapl:online",
|
||||
rapl_cpu_online, rapl_cpu_offline);
|
||||
if (ret)
|
||||
goto out1;
|
||||
|
@@ -1398,22 +1398,22 @@ static int __init intel_uncore_init(void)
|
||||
*/
|
||||
if (!cret) {
|
||||
ret = cpuhp_setup_state(CPUHP_PERF_X86_UNCORE_PREP,
|
||||
"PERF_X86_UNCORE_PREP",
|
||||
uncore_cpu_prepare, NULL);
|
||||
"perf/x86/intel/uncore:prepare",
|
||||
uncore_cpu_prepare, NULL);
|
||||
if (ret)
|
||||
goto err;
|
||||
} else {
|
||||
cpuhp_setup_state_nocalls(CPUHP_PERF_X86_UNCORE_PREP,
|
||||
"PERF_X86_UNCORE_PREP",
|
||||
"perf/x86/intel/uncore:prepare",
|
||||
uncore_cpu_prepare, NULL);
|
||||
}
|
||||
first_init = 1;
|
||||
cpuhp_setup_state(CPUHP_AP_PERF_X86_UNCORE_STARTING,
|
||||
"AP_PERF_X86_UNCORE_STARTING",
|
||||
"perf/x86/uncore:starting",
|
||||
uncore_cpu_starting, uncore_cpu_dying);
|
||||
first_init = 0;
|
||||
cpuhp_setup_state(CPUHP_AP_PERF_X86_UNCORE_ONLINE,
|
||||
"AP_PERF_X86_UNCORE_ONLINE",
|
||||
"perf/x86/uncore:online",
|
||||
uncore_event_cpu_online, uncore_event_cpu_offline);
|
||||
return 0;
|
||||
|
||||
|
@@ -234,7 +234,7 @@ static __init int apbt_late_init(void)
|
||||
if (intel_mid_timer_options == INTEL_MID_TIMER_LAPIC_APBT ||
|
||||
!apb_timer_block_enabled)
|
||||
return 0;
|
||||
return cpuhp_setup_state(CPUHP_X86_APB_DEAD, "X86_APB_DEAD", NULL,
|
||||
return cpuhp_setup_state(CPUHP_X86_APB_DEAD, "x86/apb:dead", NULL,
|
||||
apbt_cpu_dead);
|
||||
}
|
||||
fs_initcall(apbt_late_init);
|
||||
|
@@ -191,7 +191,7 @@ static int x2apic_cluster_probe(void)
|
||||
if (!x2apic_mode)
|
||||
return 0;
|
||||
|
||||
ret = cpuhp_setup_state(CPUHP_X2APIC_PREPARE, "X2APIC_PREPARE",
|
||||
ret = cpuhp_setup_state(CPUHP_X2APIC_PREPARE, "x86/x2apic:prepare",
|
||||
x2apic_prepare_cpu, x2apic_dead_cpu);
|
||||
if (ret < 0) {
|
||||
pr_err("Failed to register X2APIC_PREPARE\n");
|
||||
|
@@ -1051,11 +1051,11 @@ static __init int hpet_late_init(void)
|
||||
return 0;
|
||||
|
||||
/* This notifier should be called after workqueue is ready */
|
||||
ret = cpuhp_setup_state(CPUHP_AP_X86_HPET_ONLINE, "AP_X86_HPET_ONLINE",
|
||||
ret = cpuhp_setup_state(CPUHP_AP_X86_HPET_ONLINE, "x86/hpet:online",
|
||||
hpet_cpuhp_online, NULL);
|
||||
if (ret)
|
||||
return ret;
|
||||
ret = cpuhp_setup_state(CPUHP_X86_HPET_DEAD, "X86_HPET_DEAD", NULL,
|
||||
ret = cpuhp_setup_state(CPUHP_X86_HPET_DEAD, "x86/hpet:dead", NULL,
|
||||
hpet_cpuhp_dead);
|
||||
if (ret)
|
||||
goto err_cpuhp;
|
||||
|
@@ -408,7 +408,7 @@ static __init int tboot_late_init(void)
|
||||
tboot_create_trampoline();
|
||||
|
||||
atomic_set(&ap_wfs_count, 0);
|
||||
cpuhp_setup_state(CPUHP_AP_X86_TBOOT_DYING, "AP_X86_TBOOT_DYING", NULL,
|
||||
cpuhp_setup_state(CPUHP_AP_X86_TBOOT_DYING, "x86/tboot:dying", NULL,
|
||||
tboot_dying_cpu);
|
||||
#ifdef CONFIG_DEBUG_FS
|
||||
debugfs_create_file("tboot_log", S_IRUSR,
|
||||
|
@@ -5855,7 +5855,7 @@ static void kvm_timer_init(void)
|
||||
}
|
||||
pr_debug("kvm: max_tsc_khz = %ld\n", max_tsc_khz);
|
||||
|
||||
cpuhp_setup_state(CPUHP_AP_X86_KVM_CLK_ONLINE, "AP_X86_KVM_CLK_ONLINE",
|
||||
cpuhp_setup_state(CPUHP_AP_X86_KVM_CLK_ONLINE, "x86/kvm/clk:online",
|
||||
kvmclock_cpu_online, kvmclock_cpu_down_prep);
|
||||
}
|
||||
|
||||
|
@@ -1529,11 +1529,11 @@ static int xen_cpuhp_setup(void)
|
||||
int rc;
|
||||
|
||||
rc = cpuhp_setup_state_nocalls(CPUHP_XEN_PREPARE,
|
||||
"XEN_HVM_GUEST_PREPARE",
|
||||
"x86/xen/hvm_guest:prepare",
|
||||
xen_cpu_up_prepare, xen_cpu_dead);
|
||||
if (rc >= 0) {
|
||||
rc = cpuhp_setup_state_nocalls(CPUHP_AP_ONLINE_DYN,
|
||||
"XEN_HVM_GUEST_ONLINE",
|
||||
"x86/xen/hvm_guest:online",
|
||||
xen_cpu_up_online, NULL);
|
||||
if (rc < 0)
|
||||
cpuhp_remove_state_nocalls(CPUHP_XEN_PREPARE);
|
||||
|
Référencer dans un nouveau ticket
Bloquer un utilisateur