xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: siano: fix device register error path

Browse Source 
[ Upstream commit 5368b1ee2939961a16e74972b69088433fc52195 ]

As reported by smatch:
	drivers/media/common/siano/smsdvb-main.c:1231 smsdvb_hotplug() warn: '&client->entry' not removed from list

If an error occur at the end of the registration logic, it won't
drop the device from the list.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Mauro Carvalho Chehab
2021-06-10 08:57:02 +02:00
committed by Greg Kroah-Hartman
parent cc4ba5a397
commit 72962620ef
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/common/siano/smsdvb-main.c
View File

@@ -1176,6 +1176,10 @@ static int smsdvb_hotplug(struct smscore_device_t *coredev,
return 0; return 0;
media_graph_error: media_graph_error:
mutex_lock(&g_smsdvb_clientslock);
list_del(&client->entry);
mutex_unlock(&g_smsdvb_clientslock);
smsdvb_debugfs_release(client); smsdvb_debugfs_release(client);
client_error: client_error: