powerpc/mm: cleanup ifdef mess in add_huge_page_size()
Introduce a subarch specific helper check_and_get_huge_psize() to check the huge page sizes and cleanup the ifdef mess in add_huge_page_size() Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
This commit is contained in:

committed by
Michael Ellerman

parent
5fb84fec46
commit
723f268f19
@@ -107,4 +107,31 @@ static inline void hugepd_populate(hugepd_t *hpdp, pte_t *new, unsigned int pshi
|
||||
|
||||
void flush_hugetlb_page(struct vm_area_struct *vma, unsigned long vmaddr);
|
||||
|
||||
static inline int check_and_get_huge_psize(int shift)
|
||||
{
|
||||
int mmu_psize;
|
||||
|
||||
if (shift > SLICE_HIGH_SHIFT)
|
||||
return -EINVAL;
|
||||
|
||||
mmu_psize = shift_to_mmu_psize(shift);
|
||||
|
||||
/*
|
||||
* We need to make sure that for different page sizes reported by
|
||||
* firmware we only add hugetlb support for page sizes that can be
|
||||
* supported by linux page table layout.
|
||||
* For now we have
|
||||
* Radix: 2M and 1G
|
||||
* Hash: 16M and 16G
|
||||
*/
|
||||
if (radix_enabled()) {
|
||||
if (mmu_psize != MMU_PAGE_2M && mmu_psize != MMU_PAGE_1G)
|
||||
return -EINVAL;
|
||||
} else {
|
||||
if (mmu_psize != MMU_PAGE_16M && mmu_psize != MMU_PAGE_16G)
|
||||
return -EINVAL;
|
||||
}
|
||||
return mmu_psize;
|
||||
}
|
||||
|
||||
#endif
|
||||
|
@@ -36,4 +36,9 @@ static inline void hugepd_populate(hugepd_t *hpdp, pte_t *new, unsigned int pshi
|
||||
(pshift == PAGE_SHIFT_8M ? _PMD_PAGE_8M : _PMD_PAGE_512K));
|
||||
}
|
||||
|
||||
static inline int check_and_get_huge_psize(int shift)
|
||||
{
|
||||
return shift_to_mmu_psize(shift);
|
||||
}
|
||||
|
||||
#endif /* _ASM_POWERPC_NOHASH_32_HUGETLB_8XX_H */
|
||||
|
@@ -34,4 +34,12 @@ static inline void hugepd_populate(hugepd_t *hpdp, pte_t *new, unsigned int pshi
|
||||
*hpdp = __hugepd(((unsigned long)new & ~PD_HUGE) | pshift);
|
||||
}
|
||||
|
||||
static inline int check_and_get_huge_psize(int shift)
|
||||
{
|
||||
if (shift & 1) /* Not a power of 4 */
|
||||
return -EINVAL;
|
||||
|
||||
return shift_to_mmu_psize(shift);
|
||||
}
|
||||
|
||||
#endif /* _ASM_POWERPC_NOHASH_HUGETLB_BOOK3E_H */
|
||||
|
Reference in New Issue
Block a user