xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ext4: initialize err_blk before calling __ext4_get_inode_loc

Browse Source 
commit c27c29c6af4f3f4ce925a2111c256733c5a5b430 upstream.

It is not guaranteed that __ext4_get_inode_loc will definitely set
err_blk pointer when it returns EIO. To avoid using uninitialized
variables, let's first set err_blk to 0.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Link: https://lore.kernel.org/r/20211201163421.2631661-1-harshads@google.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Harshad Shirwadkar
2021-12-01 08:34:21 -08:00
committed by Greg Kroah-Hartman
parent f9ed0ea0a9
commit 720508dd11
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
fs/ext4/inode.c
View File

@@ -4445,7 +4445,7 @@ has_buffer:
static int __ext4_get_inode_loc_noinmem(struct inode *inode, static int __ext4_get_inode_loc_noinmem(struct inode *inode,
struct ext4_iloc *iloc) struct ext4_iloc *iloc)
{ {
ext4_fsblk_t err_blk; ext4_fsblk_t err_blk = 0;
int ret; int ret;
ret = __ext4_get_inode_loc(inode->i_sb, inode->i_ino, iloc, 0, ret = __ext4_get_inode_loc(inode->i_sb, inode->i_ino, iloc, 0,
@@ -4460,7 +4460,7 @@ static int __ext4_get_inode_loc_noinmem(struct inode *inode,
int ext4_get_inode_loc(struct inode *inode, struct ext4_iloc *iloc) int ext4_get_inode_loc(struct inode *inode, struct ext4_iloc *iloc)
{ {
ext4_fsblk_t err_blk; ext4_fsblk_t err_blk = 0;
int ret; int ret;
/* We have all inode data except xattrs in memory here. */ /* We have all inode data except xattrs in memory here. */