xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ethtool: ethnl_set_linkmodes: remove redundant null check

Browse Source 
info cannot be NULL here since its being accessed earlier
in the function: nlmsg_parse(info->nlhdr...). Remove this
redundant NULL check.

Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Gaurav Singh
2020-07-31 00:58:44 -04:00
committed by David S. Miller
parent 9aba6c5b49
commit 71fed0bc86
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
net/ethtool/linkmodes.c
View File

@@ -421,7 +421,6 @@ int ethnl_set_linkmodes(struct sk_buff *skb, struct genl_info *info)
ret = __ethtool_get_link_ksettings(dev, &ksettings); ret = __ethtool_get_link_ksettings(dev, &ksettings);
if (ret < 0) { if (ret < 0) {
if (info)
GENL_SET_ERR_MSG(info, "failed to retrieve link settings"); GENL_SET_ERR_MSG(info, "failed to retrieve link settings");
goto out_ops; goto out_ops;
} }