xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bus: subsys: update return type of ->remove_dev() to void

Browse Source 
Its return value is not used by the subsys core and nothing meaningful
can be done with it, even if we want to use it. The subsys device is
anyway getting removed.

Update prototype of ->remove_dev() to make its return type as void. Fix
all usage sites as well.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Viresh Kumar
2015-07-30 15:04:01 +05:30
committed by Greg Kroah-Hartman
parent 52cdbdd498
commit 71db87ba57
6 changed files with 14 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/cpufreq/cpufreq.c
View File

@@ -1518,7 +1518,7 @@ static int __cpufreq_remove_dev_finish(struct device *dev,
*
* Removes the cpufreq interface for a CPU device.
*/
static int cpufreq_remove_dev(struct device *dev, struct subsys_interface *sif)
static void cpufreq_remove_dev(struct device *dev, struct subsys_interface *sif)
{
unsigned int cpu = dev->id;
int ret;
@@ -1533,7 +1533,7 @@ static int cpufreq_remove_dev(struct device *dev, struct subsys_interface *sif)
struct cpumask mask;
if (!policy)
return 0;
return;
cpumask_copy(&mask, policy->related_cpus);
cpumask_clear_cpu(cpu, &mask);
@@ -1544,19 +1544,17 @@ static int cpufreq_remove_dev(struct device *dev, struct subsys_interface *sif)
*/
if (cpumask_intersects(&mask, cpu_present_mask)) {
remove_cpu_dev_symlink(policy, cpu);
return 0;
return;
}
cpufreq_policy_free(policy, true);
return 0;
return;
}
ret = __cpufreq_remove_dev_prepare(dev, sif);
if (!ret)
ret = __cpufreq_remove_dev_finish(dev, sif);
return ret;
__cpufreq_remove_dev_finish(dev, sif);
}
static void handle_update(struct work_struct *work)