reiserfs: Make cancel_old_flush() reliable
Currently canceling of delayed work that flushes old data using cancel_old_flush() does not prevent work from being requeued. Thus in theory new work can be queued after cancel_old_flush() from reiserfs_freeze() has run. This will become larger problem once flush_old_commits() can requeue the work itself. Fix the problem by recording in sbi->work_queue that flushing work is canceled and should not be requeued. Signed-off-by: Jan Kara <jack@suse.cz>
This commit is contained in:
@@ -1961,7 +1961,7 @@ static int do_journal_release(struct reiserfs_transaction_handle *th,
|
||||
* will be requeued because superblock is being shutdown and doesn't
|
||||
* have MS_ACTIVE set.
|
||||
*/
|
||||
cancel_delayed_work_sync(&REISERFS_SB(sb)->old_work);
|
||||
reiserfs_cancel_old_flush(sb);
|
||||
/* wait for all commits to finish */
|
||||
cancel_delayed_work_sync(&SB_JOURNAL(sb)->j_work);
|
||||
|
||||
|
Reference in New Issue
Block a user