ila: allow configuration of identifier type
Allow identifier to be explicitly configured for a mapping. This can either be one of the identifier types specified in the ILA draft or a value of ILA_ATYPE_USE_FORMAT which means the identifier type is inferred from the identifier type field. If a value other than ILA_ATYPE_USE_FORMAT is set for a mapping then it is assumed that the identifier type field is not present in an identifier. Signed-off-by: Tom Herbert <tom@quantonium.net> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
84287bb328
commit
70d5aef48a
@@ -114,6 +114,7 @@ drop:
|
||||
static const struct nla_policy ila_nl_policy[ILA_ATTR_MAX + 1] = {
|
||||
[ILA_ATTR_LOCATOR] = { .type = NLA_U64, },
|
||||
[ILA_ATTR_CSUM_MODE] = { .type = NLA_U8, },
|
||||
[ILA_ATTR_IDENT_TYPE] = { .type = NLA_U8, },
|
||||
};
|
||||
|
||||
static int ila_build_state(struct nlattr *nla,
|
||||
@@ -127,19 +128,14 @@ static int ila_build_state(struct nlattr *nla,
|
||||
struct lwtunnel_state *newts;
|
||||
const struct fib6_config *cfg6 = cfg;
|
||||
struct ila_addr *iaddr;
|
||||
u8 ident_type = ILA_ATYPE_USE_FORMAT;
|
||||
u8 csum_mode = ILA_CSUM_NO_ACTION;
|
||||
u8 eff_ident_type;
|
||||
int ret;
|
||||
|
||||
if (family != AF_INET6)
|
||||
return -EINVAL;
|
||||
|
||||
if (cfg6->fc_dst_len < 8 * sizeof(struct ila_locator) + 3) {
|
||||
/* Need to have full locator and at least type field
|
||||
* included in destination
|
||||
*/
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
ret = nla_parse_nested(tb, ILA_ATTR_MAX, nla, ila_nl_policy, extack);
|
||||
if (ret < 0)
|
||||
return ret;
|
||||
@@ -149,6 +145,41 @@ static int ila_build_state(struct nlattr *nla,
|
||||
|
||||
iaddr = (struct ila_addr *)&cfg6->fc_dst;
|
||||
|
||||
if (tb[ILA_ATTR_IDENT_TYPE])
|
||||
ident_type = nla_get_u8(tb[ILA_ATTR_IDENT_TYPE]);
|
||||
|
||||
if (ident_type == ILA_ATYPE_USE_FORMAT) {
|
||||
/* Infer identifier type from type field in formatted
|
||||
* identifier.
|
||||
*/
|
||||
|
||||
if (cfg6->fc_dst_len < 8 * sizeof(struct ila_locator) + 3) {
|
||||
/* Need to have full locator and at least type field
|
||||
* included in destination
|
||||
*/
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
eff_ident_type = iaddr->ident.type;
|
||||
} else {
|
||||
eff_ident_type = ident_type;
|
||||
}
|
||||
|
||||
switch (eff_ident_type) {
|
||||
case ILA_ATYPE_IID:
|
||||
/* Don't allow ILA for IID type */
|
||||
return -EINVAL;
|
||||
case ILA_ATYPE_LUID:
|
||||
break;
|
||||
case ILA_ATYPE_VIRT_V4:
|
||||
case ILA_ATYPE_VIRT_UNI_V6:
|
||||
case ILA_ATYPE_VIRT_MULTI_V6:
|
||||
case ILA_ATYPE_NONLOCAL_ADDR:
|
||||
/* These ILA formats are not supported yet. */
|
||||
default:
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
if (tb[ILA_ATTR_CSUM_MODE])
|
||||
csum_mode = nla_get_u8(tb[ILA_ATTR_CSUM_MODE]);
|
||||
|
||||
@@ -174,6 +205,7 @@ static int ila_build_state(struct nlattr *nla,
|
||||
p = ila_params_lwtunnel(newts);
|
||||
|
||||
p->csum_mode = csum_mode;
|
||||
p->ident_type = ident_type;
|
||||
p->locator.v64 = (__force __be64)nla_get_u64(tb[ILA_ATTR_LOCATOR]);
|
||||
|
||||
/* Precompute checksum difference for translation since we
|
||||
@@ -208,9 +240,13 @@ static int ila_fill_encap_info(struct sk_buff *skb,
|
||||
if (nla_put_u64_64bit(skb, ILA_ATTR_LOCATOR, (__force u64)p->locator.v64,
|
||||
ILA_ATTR_PAD))
|
||||
goto nla_put_failure;
|
||||
|
||||
if (nla_put_u8(skb, ILA_ATTR_CSUM_MODE, (__force u8)p->csum_mode))
|
||||
goto nla_put_failure;
|
||||
|
||||
if (nla_put_u8(skb, ILA_ATTR_IDENT_TYPE, (__force u8)p->ident_type))
|
||||
goto nla_put_failure;
|
||||
|
||||
return 0;
|
||||
|
||||
nla_put_failure:
|
||||
@@ -221,6 +257,7 @@ static int ila_encap_nlsize(struct lwtunnel_state *lwtstate)
|
||||
{
|
||||
return nla_total_size_64bit(sizeof(u64)) + /* ILA_ATTR_LOCATOR */
|
||||
nla_total_size(sizeof(u8)) + /* ILA_ATTR_CSUM_MODE */
|
||||
nla_total_size(sizeof(u8)) + /* ILA_ATTR_IDENT_TYPE */
|
||||
0;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user