[PATCH] for_each_possible_cpu: network codes
for_each_cpu() actually iterates across all possible CPUs. We've had mistakes in the past where people were using for_each_cpu() where they should have been iterating across only online or present CPUs. This is inefficient and possibly buggy. We're renaming for_each_cpu() to for_each_possible_cpu() to avoid this in the future. This patch replaces for_each_cpu with for_each_possible_cpu under /net Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Acked-by: "David S. Miller" <davem@davemloft.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:

committed by
Linus Torvalds

parent
dd7ba3b8b1
commit
6f91204225
@@ -3346,7 +3346,7 @@ static int __init net_dev_init(void)
|
||||
* Initialise the packet receive queues.
|
||||
*/
|
||||
|
||||
for_each_cpu(i) {
|
||||
for_each_possible_cpu(i) {
|
||||
struct softnet_data *queue;
|
||||
|
||||
queue = &per_cpu(softnet_data, i);
|
||||
|
@@ -79,7 +79,7 @@ static void flow_cache_new_hashrnd(unsigned long arg)
|
||||
{
|
||||
int i;
|
||||
|
||||
for_each_cpu(i)
|
||||
for_each_possible_cpu(i)
|
||||
flow_hash_rnd_recalc(i) = 1;
|
||||
|
||||
flow_hash_rnd_timer.expires = jiffies + FLOW_HASH_RND_PERIOD;
|
||||
@@ -361,7 +361,7 @@ static int __init flow_cache_init(void)
|
||||
flow_hash_rnd_timer.expires = jiffies + FLOW_HASH_RND_PERIOD;
|
||||
add_timer(&flow_hash_rnd_timer);
|
||||
|
||||
for_each_cpu(i)
|
||||
for_each_possible_cpu(i)
|
||||
flow_cache_cpu_prepare(i);
|
||||
|
||||
hotcpu_notifier(flow_cache_cpu, 0);
|
||||
|
@@ -1627,7 +1627,7 @@ static int neightbl_fill_info(struct neigh_table *tbl, struct sk_buff *skb,
|
||||
|
||||
memset(&ndst, 0, sizeof(ndst));
|
||||
|
||||
for_each_cpu(cpu) {
|
||||
for_each_possible_cpu(cpu) {
|
||||
struct neigh_statistics *st;
|
||||
|
||||
st = per_cpu_ptr(tbl->stats, cpu);
|
||||
|
@@ -121,7 +121,7 @@ void __init net_random_init(void)
|
||||
{
|
||||
int i;
|
||||
|
||||
for_each_cpu(i) {
|
||||
for_each_possible_cpu(i) {
|
||||
struct nrnd_state *state = &per_cpu(net_rand_state,i);
|
||||
__net_srandom(state, i+jiffies);
|
||||
}
|
||||
@@ -133,7 +133,7 @@ static int net_random_reseed(void)
|
||||
unsigned long seed[NR_CPUS];
|
||||
|
||||
get_random_bytes(seed, sizeof(seed));
|
||||
for_each_cpu(i) {
|
||||
for_each_possible_cpu(i) {
|
||||
struct nrnd_state *state = &per_cpu(net_rand_state,i);
|
||||
__net_srandom(state, seed[i]);
|
||||
}
|
||||
|
Reference in New Issue
Block a user