xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/omap: Don't call .set_timings() operation recursively

Browse Source 
Instead of calling the .set_timings() operation recursively from the
display device backwards, iterate over the devices manually in the DRM
encoder code. This moves the complexity to a single central location and
simplifies the logic in omap_dss_device drivers.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
This commit is contained in:
Laurent Pinchart
2018-06-07 19:55:04 +03:00
committed by Tomi Valkeinen
parent d8dbe79143
commit 6ea4843095
19 changed files with 8 additions and 144 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/gpu/drm/omapdrm/omap_encoder.c
View File

@@ -58,7 +58,6 @@ static void omap_encoder_mode_set(struct drm_encoder *encoder,
{
struct drm_device *dev = encoder->dev;
struct omap_encoder *omap_encoder = to_omap_encoder(encoder);
struct omap_dss_device *display = omap_encoder->display;
struct drm_connector *connector;
struct omap_dss_device *dssdev;
struct videomode vm = { 0 };
@@ -104,18 +103,15 @@ static void omap_encoder_mode_set(struct drm_encoder *encoder,
}
}
/*
* HACK: Call the .set_timings() operation if available, this will
* eventually store timings in the CRTC. Otherwise (for DSI outputs)
* store the timings directly.
*
* All outputs should be brought in sync to operate similarly.
*/
if (display->ops->set_timings)
display->ops->set_timings(display, &vm);
else
*omap_crtc_timings(encoder->crtc) = vm;
/* Set timings for all devices in the display pipeline. */
dss_mgr_set_timings(omap_encoder->output, &vm);
for (dssdev = omap_encoder->output; dssdev; dssdev = dssdev->next) {
if (dssdev->ops->set_timings)
dssdev->ops->set_timings(dssdev, &vm);
}
/* Set the HDMI mode and HDMI infoframe if applicable. */
hdmi_mode = false;
list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
if (connector->encoder == encoder) {