xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

IB/rxe: Fix incorrect cache cleanup in error flow

Browse Source 
Array iterator stays at the same slot, fix it.

Fixes: 8700e3e7c4 ("Soft RoCE driver")
Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Zhu Yanjun <yanjun.zhu@oracle.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
This commit is contained in:
Yuval Shaia
2018-12-09 15:53:49 +02:00
committed by Jason Gunthorpe
parent 0c1c388044
commit 6db21d8986
1 changed files with 14 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
drivers/infiniband/sw/rxe/rxe_pool.c
View File

@@ -112,6 +112,18 @@ static inline struct kmem_cache *pool_cache(struct rxe_pool *pool)
return rxe_type_info[pool->type].cache; return rxe_type_info[pool->type].cache;
} }
static void rxe_cache_clean(size_t cnt)
{
int i;
struct rxe_type_info *type;
for (i = 0; i < cnt; i++) {
type = &rxe_type_info[i];
kmem_cache_destroy(type->cache);
type->cache = NULL;
}
}
int rxe_cache_init(void) int rxe_cache_init(void)
{ {
int err; int err;
@@ -136,24 +148,14 @@ int rxe_cache_init(void)
return 0; return 0;
err1: err1:
while (--i >= 0) { rxe_cache_clean(i);
kmem_cache_destroy(type->cache);
type->cache = NULL;
}
return err; return err;
} }
void rxe_cache_exit(void) void rxe_cache_exit(void)
{ {
int i; rxe_cache_clean(RXE_NUM_TYPES);
struct rxe_type_info *type;
for (i = 0; i < RXE_NUM_TYPES; i++) {
type = &rxe_type_info[i];
kmem_cache_destroy(type->cache);
type->cache = NULL;
}
} }
static int rxe_pool_init_index(struct rxe_pool *pool, u32 max, u32 min) static int rxe_pool_init_index(struct rxe_pool *pool, u32 max, u32 min)