i387: don't ever touch TS_USEDFPU directly, use helper functions

This creates three helper functions that do the TS_USEDFPU accesses, and
makes everybody that used to do it by hand use those helpers instead.

In addition, there's a couple of helper functions for the "change both
CR0.TS and TS_USEDFPU at the same time" case, and the places that do
that together have been changed to use those.  That means that we have
fewer random places that open-code this situation.

The intent is partly to clarify the code without actually changing any
semantics yet (since we clearly still have some hard to reproduce bug in
this area), but also to make it much easier to use another approach
entirely to caching the CR0.TS bit for software accesses.

Right now we use a bit in the thread-info 'status' variable (this patch
does not change that), but we might want to make it a full field of its
own or even make it a per-cpu variable.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Linus Torvalds
2012-02-16 13:33:12 -08:00
parent b6c66418dc
commit 6d59d7a9f5
4 changed files with 58 additions and 23 deletions

View File

@@ -588,7 +588,7 @@ void __math_state_restore(void)
return;
}
thread->status |= TS_USEDFPU; /* So we fnsave on switch_to() */
__thread_set_has_fpu(thread); /* clts in caller! */
tsk->fpu_counter++;
}

View File

@@ -47,7 +47,7 @@ void __sanitize_i387_state(struct task_struct *tsk)
if (!fx)
return;
BUG_ON(task_thread_info(tsk)->status & TS_USEDFPU);
BUG_ON(__thread_has_fpu(task_thread_info(tsk)));
xstate_bv = tsk->thread.fpu.state->xsave.xsave_hdr.xstate_bv;