fs: use helper bio_add_page() instead of open coding on bi_io_vec
Call pre-defined helper bio_add_page() instead of open coding for iterating through bi_io_vec[]. Doing that, it's possible to make some parts in filesystems and mm/page_io.c simpler than before. Acked-by: Dave Kleikamp <shaggy@kernel.org> Cc: Christoph Hellwig <hch@infradead.org> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: linux-fsdevel@vger.kernel.org Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com> [dpark: add more description in commit message] Signed-off-by: Dongsu Park <dpark@posteo.net> Signed-off-by: Ming Lin <ming.l@ssi.samsung.com> Signed-off-by: Jens Axboe <axboe@fb.com>
This commit is contained in:
committed by
Jens Axboe
parent
8ae126660f
commit
6cf66b4caf
@@ -33,12 +33,10 @@ static struct bio *get_swap_bio(gfp_t gfp_flags,
|
||||
if (bio) {
|
||||
bio->bi_iter.bi_sector = map_swap_page(page, &bio->bi_bdev);
|
||||
bio->bi_iter.bi_sector <<= PAGE_SHIFT - 9;
|
||||
bio->bi_io_vec[0].bv_page = page;
|
||||
bio->bi_io_vec[0].bv_len = PAGE_SIZE;
|
||||
bio->bi_io_vec[0].bv_offset = 0;
|
||||
bio->bi_vcnt = 1;
|
||||
bio->bi_iter.bi_size = PAGE_SIZE;
|
||||
bio->bi_end_io = end_io;
|
||||
|
||||
bio_add_page(bio, page, PAGE_SIZE, 0);
|
||||
BUG_ON(bio->bi_iter.bi_size != PAGE_SIZE);
|
||||
}
|
||||
return bio;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user