NFS: merge _full and _partial write rpc_ops
Decouple nfs_pgio_header and nfs_write_data, and have (possibly multiple) nfs_write_datas each take a refcount on nfs_pgio_header. For the moment keeps nfs_write_header as a way to preallocate a single nfs_write_data with the nfs_pgio_header. The code doesn't need this, and would be prettier without, but given the amount of churn I am already introducing I didn't want to play with tuning new mempools. This also fixes bug in pnfs_ld_handle_write_error. In the case of desc->pg_bsize < PAGE_CACHE_SIZE, the pages list was empty, causing replay attempt to do nothing. Signed-off-by: Fred Isaman <iisaman@netapp.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
This commit is contained in:

committed by
Trond Myklebust

parent
4db6e0b74c
commit
6c75dc0d49
@@ -3431,8 +3431,6 @@ void nfs4_reset_write(struct rpc_task *task, struct nfs_write_data *data)
|
||||
struct inode *inode = hdr->inode;
|
||||
|
||||
dprintk("%s Reset task for i/o through\n", __func__);
|
||||
put_lseg(hdr->lseg);
|
||||
hdr->lseg = NULL;
|
||||
data->ds_clp = NULL;
|
||||
data->write_done_cb = nfs4_write_done_cb;
|
||||
data->args.fh = NFS_FH(inode);
|
||||
@@ -3448,7 +3446,7 @@ static void nfs4_proc_write_setup(struct nfs_write_data *data, struct rpc_messag
|
||||
{
|
||||
struct nfs_server *server = NFS_SERVER(data->header->inode);
|
||||
|
||||
if (data->header->lseg) {
|
||||
if (data->ds_clp) {
|
||||
data->args.bitmask = NULL;
|
||||
data->res.fattr = NULL;
|
||||
} else
|
||||
|
Reference in New Issue
Block a user