Merge tag 'drm-misc-next-2019-12-16' of git://anongit.freedesktop.org/drm/drm-misc into drm-next
drm-misc-next for v5.6: UAPI Changes: - Add support for DMA-BUF HEAPS. Cross-subsystem Changes: - mipi dsi definition updates, pulled into drm-intel as well. - Add lockdep annotations for dma_resv vs mmap_sem and fs_reclaim. - Remove support for dma-buf kmap/kunmap. - Constify fb_ops in all fbdev drivers, including drm drivers and drm-core, and media as well. Core Changes: - Small cleanups to ttm. - Fix SCDC definition. - Assorted cleanups to core. - Add todo to remove load/unload hooks, and use generic fbdev emulation. - Assorted documentation updates. - Use blocking ww lock in ttm fault handler. - Remove drm_fb_helper_fbdev_setup/teardown. - Warning fixes with W=1 for atomic. - Use drm_debug_enabled() instead of drm_debug flag testing in various drivers. - Fallback to nontiled mode in fbdev emulation when not all tiles are present. (Later on reverted) - Various kconfig indentation fixes in core and drivers. - Fix freeing transactions in dp-mst correctly. - Sean Paul is steping down as core maintainer. :-( - Add lockdep annotations for atomic locks vs dma-resv. - Prevent use-after-free for a bad job in drm_scheduler. - Fill out all block sizes in the P01x and P210 definitions. - Avoid division by zero in drm/rect, and fix bounds. - Add drm/rect selftests. - Add aspect ratio and alternate clocks for HDMI 4k modes. - Add todo for drm_framebuffer_funcs and fb_create cleanup. - Drop DRM_AUTH for prime import/export ioctls. - Clear DP-MST payload id tables downstream when initializating. - Fix for DSC throughput definition. - Add extra FEC definitions. - Fix fake offset in drm_gem_object_funs.mmap. - Stop using encoder->bridge in core directly - Handle bridge chaining slightly better. - Add backlight support to drm/panel, and use it in many panel drivers. - Increase max number of y420 modes from 128 to 256, as preparation to add the new modes. Driver Changes: - Small fixes all over. - Fix documentation in vkms. - Fix mmap_sem vs dma_resv in nouveau. - Small cleanup in komeda. - Add page flip support in gma500 for psb/cdv. - Add ddc symlink in the connector sysfs directory for many drivers. - Add support for analogic an6345, and fix small bugs in it. - Add atomic modesetting support to ast. - Fix radeon fault handler VMA race. - Switch udl to use generic shmem helpers. - Unconditional vblank handling for mcde. - Miscellaneous fixes to mcde. - Tweak debug output from komeda using debugfs. - Add gamma and color transform support to komeda for DOU-IPS. - Add support for sony acx424AKP panel. - Various small cleanups to gma500. - Use generic fbdev emulation in udl, and replace udl_framebuffer with generic implementation. - Add support for Logic PD Type 28 panel. - Use drm_panel_* wrapper functions in exynos/tegra/msm. - Add devicetree bindings for generic DSI panels. - Don't include drm_pci.h directly in many drivers. - Add support for begin/end_cpu_access in udmabuf. - Stop using drm_get_pci_dev in gma500 and mga200. - Fixes to UDL damage handling, and use dma_buf_begin/end_cpu_access. - Add devfreq thermal support to panfrost. - Fix hotplug with daisy chained monitors by removing VCPI when disabling topology manager. - meson: Add support for OSD1 plane AFBC commit. - Stop displaying garbage when toggling ast primary plane on/off. - More cleanups and fixes to UDL. - Add D32 suport to komeda. - Remove globle copy of drm_dev in gma500. - Add support for Boe Himax8279d MIPI-DSI LCD panel. - Add support for ingenic JZ4770 panel. - Small null pointer deference fix in ingenic. - Remove support for the special tfp420 driver, as there is a generic way to do it. Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/ba73535a-9334-5302-2e1f-5208bd7390bd@linux.intel.com
This commit is contained in:
@@ -419,6 +419,7 @@ mode_fixup(struct drm_atomic_state *state)
|
||||
for_each_new_connector_in_state(state, connector, new_conn_state, i) {
|
||||
const struct drm_encoder_helper_funcs *funcs;
|
||||
struct drm_encoder *encoder;
|
||||
struct drm_bridge *bridge;
|
||||
|
||||
WARN_ON(!!new_conn_state->best_encoder != !!new_conn_state->crtc);
|
||||
|
||||
@@ -435,8 +436,10 @@ mode_fixup(struct drm_atomic_state *state)
|
||||
encoder = new_conn_state->best_encoder;
|
||||
funcs = encoder->helper_private;
|
||||
|
||||
ret = drm_bridge_mode_fixup(encoder->bridge, &new_crtc_state->mode,
|
||||
&new_crtc_state->adjusted_mode);
|
||||
bridge = drm_bridge_chain_get_first_bridge(encoder);
|
||||
ret = drm_bridge_chain_mode_fixup(bridge,
|
||||
&new_crtc_state->mode,
|
||||
&new_crtc_state->adjusted_mode);
|
||||
if (!ret) {
|
||||
DRM_DEBUG_ATOMIC("Bridge fixup failed\n");
|
||||
return -EINVAL;
|
||||
@@ -492,6 +495,7 @@ static enum drm_mode_status mode_valid_path(struct drm_connector *connector,
|
||||
struct drm_crtc *crtc,
|
||||
const struct drm_display_mode *mode)
|
||||
{
|
||||
struct drm_bridge *bridge;
|
||||
enum drm_mode_status ret;
|
||||
|
||||
ret = drm_encoder_mode_valid(encoder, mode);
|
||||
@@ -501,7 +505,8 @@ static enum drm_mode_status mode_valid_path(struct drm_connector *connector,
|
||||
return ret;
|
||||
}
|
||||
|
||||
ret = drm_bridge_mode_valid(encoder->bridge, mode);
|
||||
bridge = drm_bridge_chain_get_first_bridge(encoder);
|
||||
ret = drm_bridge_chain_mode_valid(bridge, mode);
|
||||
if (ret != MODE_OK) {
|
||||
DRM_DEBUG_ATOMIC("[BRIDGE] mode_valid() failed\n");
|
||||
return ret;
|
||||
@@ -984,6 +989,7 @@ disable_outputs(struct drm_device *dev, struct drm_atomic_state *old_state)
|
||||
for_each_oldnew_connector_in_state(old_state, connector, old_conn_state, new_conn_state, i) {
|
||||
const struct drm_encoder_helper_funcs *funcs;
|
||||
struct drm_encoder *encoder;
|
||||
struct drm_bridge *bridge;
|
||||
|
||||
/* Shut down everything that's in the changeset and currently
|
||||
* still on. So need to check the old, saved state. */
|
||||
@@ -1020,7 +1026,8 @@ disable_outputs(struct drm_device *dev, struct drm_atomic_state *old_state)
|
||||
* Each encoder has at most one connector (since we always steal
|
||||
* it away), so we won't call disable hooks twice.
|
||||
*/
|
||||
drm_atomic_bridge_disable(encoder->bridge, old_state);
|
||||
bridge = drm_bridge_chain_get_first_bridge(encoder);
|
||||
drm_atomic_bridge_chain_disable(bridge, old_state);
|
||||
|
||||
/* Right function depends upon target state. */
|
||||
if (funcs) {
|
||||
@@ -1034,7 +1041,7 @@ disable_outputs(struct drm_device *dev, struct drm_atomic_state *old_state)
|
||||
funcs->dpms(encoder, DRM_MODE_DPMS_OFF);
|
||||
}
|
||||
|
||||
drm_atomic_bridge_post_disable(encoder->bridge, old_state);
|
||||
drm_atomic_bridge_chain_post_disable(bridge, old_state);
|
||||
}
|
||||
|
||||
for_each_oldnew_crtc_in_state(old_state, crtc, old_crtc_state, new_crtc_state, i) {
|
||||
@@ -1188,6 +1195,7 @@ crtc_set_mode(struct drm_device *dev, struct drm_atomic_state *old_state)
|
||||
const struct drm_encoder_helper_funcs *funcs;
|
||||
struct drm_encoder *encoder;
|
||||
struct drm_display_mode *mode, *adjusted_mode;
|
||||
struct drm_bridge *bridge;
|
||||
|
||||
if (!new_conn_state->best_encoder)
|
||||
continue;
|
||||
@@ -1215,7 +1223,8 @@ crtc_set_mode(struct drm_device *dev, struct drm_atomic_state *old_state)
|
||||
funcs->mode_set(encoder, mode, adjusted_mode);
|
||||
}
|
||||
|
||||
drm_bridge_mode_set(encoder->bridge, mode, adjusted_mode);
|
||||
bridge = drm_bridge_chain_get_first_bridge(encoder);
|
||||
drm_bridge_chain_mode_set(bridge, mode, adjusted_mode);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1314,6 +1323,7 @@ void drm_atomic_helper_commit_modeset_enables(struct drm_device *dev,
|
||||
for_each_new_connector_in_state(old_state, connector, new_conn_state, i) {
|
||||
const struct drm_encoder_helper_funcs *funcs;
|
||||
struct drm_encoder *encoder;
|
||||
struct drm_bridge *bridge;
|
||||
|
||||
if (!new_conn_state->best_encoder)
|
||||
continue;
|
||||
@@ -1332,7 +1342,8 @@ void drm_atomic_helper_commit_modeset_enables(struct drm_device *dev,
|
||||
* Each encoder has at most one connector (since we always steal
|
||||
* it away), so we won't call enable hooks twice.
|
||||
*/
|
||||
drm_atomic_bridge_pre_enable(encoder->bridge, old_state);
|
||||
bridge = drm_bridge_chain_get_first_bridge(encoder);
|
||||
drm_atomic_bridge_chain_pre_enable(bridge, old_state);
|
||||
|
||||
if (funcs) {
|
||||
if (funcs->atomic_enable)
|
||||
@@ -1343,7 +1354,7 @@ void drm_atomic_helper_commit_modeset_enables(struct drm_device *dev,
|
||||
funcs->commit(encoder);
|
||||
}
|
||||
|
||||
drm_atomic_bridge_enable(encoder->bridge, old_state);
|
||||
drm_atomic_bridge_chain_enable(bridge, old_state);
|
||||
}
|
||||
|
||||
drm_atomic_helper_commit_writebacks(dev, old_state);
|
||||
@@ -1834,17 +1845,21 @@ EXPORT_SYMBOL(drm_atomic_helper_commit);
|
||||
/**
|
||||
* DOC: implementing nonblocking commit
|
||||
*
|
||||
* Nonblocking atomic commits have to be implemented in the following sequence:
|
||||
* Nonblocking atomic commits should use struct &drm_crtc_commit to sequence
|
||||
* different operations against each another. Locks, especially struct
|
||||
* &drm_modeset_lock, should not be held in worker threads or any other
|
||||
* asynchronous context used to commit the hardware state.
|
||||
*
|
||||
* 1. Run drm_atomic_helper_prepare_planes() first. This is the only function
|
||||
* which commit needs to call which can fail, so we want to run it first and
|
||||
* drm_atomic_helper_commit() implements the recommended sequence for
|
||||
* nonblocking commits, using drm_atomic_helper_setup_commit() internally:
|
||||
*
|
||||
* 1. Run drm_atomic_helper_prepare_planes(). Since this can fail and we
|
||||
* need to propagate out of memory/VRAM errors to userspace, it must be called
|
||||
* synchronously.
|
||||
*
|
||||
* 2. Synchronize with any outstanding nonblocking commit worker threads which
|
||||
* might be affected the new state update. This can be done by either cancelling
|
||||
* or flushing the work items, depending upon whether the driver can deal with
|
||||
* cancelled updates. Note that it is important to ensure that the framebuffer
|
||||
* cleanup is still done when cancelling.
|
||||
* might be affected by the new state update. This is handled by
|
||||
* drm_atomic_helper_setup_commit().
|
||||
*
|
||||
* Asynchronous workers need to have sufficient parallelism to be able to run
|
||||
* different atomic commits on different CRTCs in parallel. The simplest way to
|
||||
@@ -1855,21 +1870,29 @@ EXPORT_SYMBOL(drm_atomic_helper_commit);
|
||||
* must be done as one global operation, and enabling or disabling a CRTC can
|
||||
* take a long time. But even that is not required.
|
||||
*
|
||||
* IMPORTANT: A &drm_atomic_state update for multiple CRTCs is sequenced
|
||||
* against all CRTCs therein. Therefore for atomic state updates which only flip
|
||||
* planes the driver must not get the struct &drm_crtc_state of unrelated CRTCs
|
||||
* in its atomic check code: This would prevent committing of atomic updates to
|
||||
* multiple CRTCs in parallel. In general, adding additional state structures
|
||||
* should be avoided as much as possible, because this reduces parallelism in
|
||||
* (nonblocking) commits, both due to locking and due to commit sequencing
|
||||
* requirements.
|
||||
*
|
||||
* 3. The software state is updated synchronously with
|
||||
* drm_atomic_helper_swap_state(). Doing this under the protection of all modeset
|
||||
* locks means concurrent callers never see inconsistent state. And doing this
|
||||
* while it's guaranteed that no relevant nonblocking worker runs means that
|
||||
* nonblocking workers do not need grab any locks. Actually they must not grab
|
||||
* locks, for otherwise the work flushing will deadlock.
|
||||
* locks means concurrent callers never see inconsistent state. Note that commit
|
||||
* workers do not hold any locks; their access is only coordinated through
|
||||
* ordering. If workers would access state only through the pointers in the
|
||||
* free-standing state objects (currently not the case for any driver) then even
|
||||
* multiple pending commits could be in-flight at the same time.
|
||||
*
|
||||
* 4. Schedule a work item to do all subsequent steps, using the split-out
|
||||
* commit helpers: a) pre-plane commit b) plane commit c) post-plane commit and
|
||||
* then cleaning up the framebuffers after the old framebuffer is no longer
|
||||
* being displayed.
|
||||
*
|
||||
* The above scheme is implemented in the atomic helper libraries in
|
||||
* drm_atomic_helper_commit() using a bunch of helper functions. See
|
||||
* drm_atomic_helper_setup_commit() for a starting point.
|
||||
* being displayed. The scheduled work should synchronize against other workers
|
||||
* using the &drm_crtc_commit infrastructure as needed. See
|
||||
* drm_atomic_helper_setup_commit() for more details.
|
||||
*/
|
||||
|
||||
static int stall_checks(struct drm_crtc *crtc, bool nonblock)
|
||||
@@ -2098,7 +2121,7 @@ EXPORT_SYMBOL(drm_atomic_helper_setup_commit);
|
||||
*
|
||||
* This function waits for all preceeding commits that touch the same CRTC as
|
||||
* @old_state to both be committed to the hardware (as signalled by
|
||||
* drm_atomic_helper_commit_hw_done) and executed by the hardware (as signalled
|
||||
* drm_atomic_helper_commit_hw_done()) and executed by the hardware (as signalled
|
||||
* by calling drm_crtc_send_vblank_event() on the &drm_crtc_state.event).
|
||||
*
|
||||
* This is part of the atomic helper support for nonblocking commits, see
|
||||
|
Reference in New Issue
Block a user