xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

erofs: remove the occupied parameter from z_erofs_pagevec_enqueue()

Browse Source 
commit 7dea3de7d384f4c8156e8bd93112ba6db1eb276c upstream.

No any behavior to variable occupied in z_erofs_attach_page() which
is only caller to z_erofs_pagevec_enqueue().

Link: https://lore.kernel.org/r/20210419102623.2015-1-zbestahu@gmail.com
Signed-off-by: Yue Hu <huyue2@yulong.com>
Reviewed-by: Gao Xiang <xiang@kernel.org>
Signed-off-by: Gao Xiang <xiang@kernel.org>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Yue Hu
2021-11-16 09:08:18 +08:00
committed by Greg Kroah-Hartman
parent 5bf5f46483
commit 6c1ad56b2d
2 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
fs/erofs/zdata.c
View File

@@ -282,7 +282,6 @@ static int z_erofs_attach_page(struct z_erofs_collector *clt,
enum z_erofs_page_type type) enum z_erofs_page_type type)
{ {
int ret; int ret;
bool occupied;
/* give priority for inplaceio */ /* give priority for inplaceio */
if (clt->mode >= COLLECT_PRIMARY && if (clt->mode >= COLLECT_PRIMARY &&
@@ -290,8 +289,7 @@ static int z_erofs_attach_page(struct z_erofs_collector *clt,
z_erofs_try_inplace_io(clt, page)) z_erofs_try_inplace_io(clt, page))
return 0; return 0;
ret = z_erofs_pagevec_enqueue(&clt->vector, ret = z_erofs_pagevec_enqueue(&clt->vector, page, type);
page, type, &occupied);
clt->cl->vcnt += (unsigned int)ret; clt->cl->vcnt += (unsigned int)ret;
return ret ? 0 : -EAGAIN; return ret ? 0 : -EAGAIN;

5
fs/erofs/zpvec.h
View File

@@ -107,10 +107,8 @@ static inline void z_erofs_pagevec_ctor_init(struct z_erofs_pagevec_ctor *ctor,
static inline bool z_erofs_pagevec_enqueue(struct z_erofs_pagevec_ctor *ctor, static inline bool z_erofs_pagevec_enqueue(struct z_erofs_pagevec_ctor *ctor,
struct page *page, struct page *page,
enum z_erofs_page_type type, enum z_erofs_page_type type)
bool *occupied)
{ {
*occupied = false;
if (!ctor->next && type) if (!ctor->next && type)
if (ctor->index + 1 == ctor->nr) if (ctor->index + 1 == ctor->nr)
return false; return false;
@@ -125,7 +123,6 @@ static inline bool z_erofs_pagevec_enqueue(struct z_erofs_pagevec_ctor *ctor,
/* should remind that collector->next never equal to 1, 2 */ /* should remind that collector->next never equal to 1, 2 */
if (type == (uintptr_t)ctor->next) { if (type == (uintptr_t)ctor->next) {
ctor->next = page; ctor->next = page;
*occupied = true;
} }
ctor->pages[ctor->index++] = tagptr_fold(erofs_vtptr_t, page, type); ctor->pages[ctor->index++] = tagptr_fold(erofs_vtptr_t, page, type);
return true; return true;