tty: Convert termios_mutex to termios_rwsem
termios is commonly accessed unsafely (especially by N_TTY) because the existing mutex forces exclusive access. Convert existing usage. Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
a2f73be8ee
commit
6a1c0680cf
@@ -287,7 +287,7 @@ static int pty_resize(struct tty_struct *tty, struct winsize *ws)
|
||||
struct tty_struct *pty = tty->link;
|
||||
|
||||
/* For a PTY we need to lock the tty side */
|
||||
mutex_lock(&tty->termios_mutex);
|
||||
down_write(&tty->termios_rwsem);
|
||||
if (!memcmp(ws, &tty->winsize, sizeof(*ws)))
|
||||
goto done;
|
||||
|
||||
@@ -314,7 +314,7 @@ static int pty_resize(struct tty_struct *tty, struct winsize *ws)
|
||||
tty->winsize = *ws;
|
||||
pty->winsize = *ws; /* Never used so will go away soon */
|
||||
done:
|
||||
mutex_unlock(&tty->termios_mutex);
|
||||
up_write(&tty->termios_rwsem);
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user