xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

usb: typec: intel_pmc_mux: Put fwnode in error case during ->probe()

Browse Source 
commit 1a85b350a7741776a406005b943e3dec02c424ed upstream.

device_get_next_child_node() bumps a reference counting of a returned variable.
We have to balance it whenever we return to the caller.

Fixes: 6701adfa96 ("usb: typec: driver for Intel PMC mux control")
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210607205007.71458-1-andy.shevchenko@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Andy Shevchenko
2021-06-07 23:50:05 +03:00
committed by Greg Kroah-Hartman
parent 572de10087
commit 6900ef1b10
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/typec/mux/intel_pmc_mux.c
View File

@@ -623,8 +623,10 @@ static int pmc_usb_probe(struct platform_device *pdev)
break; break;
ret = pmc_usb_register_port(pmc, i, fwnode); ret = pmc_usb_register_port(pmc, i, fwnode);
if (ret) if (ret) {
fwnode_handle_put(fwnode);
goto err_remove_ports; goto err_remove_ports;
}
} }
platform_set_drvdata(pdev, pmc); platform_set_drvdata(pdev, pmc);