ALSA: constify snd_pcm_ops structures
Check for snd_pcm_ops structures that are only stored in the ops field of a snd_soc_platform_driver structure or passed as the third argument to snd_pcm_set_ops. The corresponding field or parameter is declared const, so snd_pcm_ops structures that have this property can be declared as const also. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r disable optional_qualifier@ identifier i; position p; @@ static struct snd_pcm_ops i@p = { ... }; @ok1@ identifier r.i; struct snd_soc_platform_driver e; position p; @@ e.ops = &i@p; @ok2@ identifier r.i; expression e1, e2; position p; @@ snd_pcm_set_ops(e1, e2, &i@p) @bad@ position p != {r.p,ok1.p,ok2.p}; identifier r.i; struct snd_pcm_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct snd_pcm_ops i = { ... }; // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Esse commit está contido em:
@@ -1109,7 +1109,7 @@ snd_ca0106_pcm_pointer_capture(struct snd_pcm_substream *substream)
|
||||
}
|
||||
|
||||
/* operators */
|
||||
static struct snd_pcm_ops snd_ca0106_playback_front_ops = {
|
||||
static const struct snd_pcm_ops snd_ca0106_playback_front_ops = {
|
||||
.open = snd_ca0106_pcm_open_playback_front,
|
||||
.close = snd_ca0106_pcm_close_playback,
|
||||
.ioctl = snd_pcm_lib_ioctl,
|
||||
@@ -1120,7 +1120,7 @@ static struct snd_pcm_ops snd_ca0106_playback_front_ops = {
|
||||
.pointer = snd_ca0106_pcm_pointer_playback,
|
||||
};
|
||||
|
||||
static struct snd_pcm_ops snd_ca0106_capture_0_ops = {
|
||||
static const struct snd_pcm_ops snd_ca0106_capture_0_ops = {
|
||||
.open = snd_ca0106_pcm_open_0_capture,
|
||||
.close = snd_ca0106_pcm_close_capture,
|
||||
.ioctl = snd_pcm_lib_ioctl,
|
||||
@@ -1131,7 +1131,7 @@ static struct snd_pcm_ops snd_ca0106_capture_0_ops = {
|
||||
.pointer = snd_ca0106_pcm_pointer_capture,
|
||||
};
|
||||
|
||||
static struct snd_pcm_ops snd_ca0106_capture_1_ops = {
|
||||
static const struct snd_pcm_ops snd_ca0106_capture_1_ops = {
|
||||
.open = snd_ca0106_pcm_open_1_capture,
|
||||
.close = snd_ca0106_pcm_close_capture,
|
||||
.ioctl = snd_pcm_lib_ioctl,
|
||||
@@ -1142,7 +1142,7 @@ static struct snd_pcm_ops snd_ca0106_capture_1_ops = {
|
||||
.pointer = snd_ca0106_pcm_pointer_capture,
|
||||
};
|
||||
|
||||
static struct snd_pcm_ops snd_ca0106_capture_2_ops = {
|
||||
static const struct snd_pcm_ops snd_ca0106_capture_2_ops = {
|
||||
.open = snd_ca0106_pcm_open_2_capture,
|
||||
.close = snd_ca0106_pcm_close_capture,
|
||||
.ioctl = snd_pcm_lib_ioctl,
|
||||
@@ -1153,7 +1153,7 @@ static struct snd_pcm_ops snd_ca0106_capture_2_ops = {
|
||||
.pointer = snd_ca0106_pcm_pointer_capture,
|
||||
};
|
||||
|
||||
static struct snd_pcm_ops snd_ca0106_capture_3_ops = {
|
||||
static const struct snd_pcm_ops snd_ca0106_capture_3_ops = {
|
||||
.open = snd_ca0106_pcm_open_3_capture,
|
||||
.close = snd_ca0106_pcm_close_capture,
|
||||
.ioctl = snd_pcm_lib_ioctl,
|
||||
@@ -1164,7 +1164,7 @@ static struct snd_pcm_ops snd_ca0106_capture_3_ops = {
|
||||
.pointer = snd_ca0106_pcm_pointer_capture,
|
||||
};
|
||||
|
||||
static struct snd_pcm_ops snd_ca0106_playback_center_lfe_ops = {
|
||||
static const struct snd_pcm_ops snd_ca0106_playback_center_lfe_ops = {
|
||||
.open = snd_ca0106_pcm_open_playback_center_lfe,
|
||||
.close = snd_ca0106_pcm_close_playback,
|
||||
.ioctl = snd_pcm_lib_ioctl,
|
||||
@@ -1175,7 +1175,7 @@ static struct snd_pcm_ops snd_ca0106_playback_center_lfe_ops = {
|
||||
.pointer = snd_ca0106_pcm_pointer_playback,
|
||||
};
|
||||
|
||||
static struct snd_pcm_ops snd_ca0106_playback_unknown_ops = {
|
||||
static const struct snd_pcm_ops snd_ca0106_playback_unknown_ops = {
|
||||
.open = snd_ca0106_pcm_open_playback_unknown,
|
||||
.close = snd_ca0106_pcm_close_playback,
|
||||
.ioctl = snd_pcm_lib_ioctl,
|
||||
@@ -1186,7 +1186,7 @@ static struct snd_pcm_ops snd_ca0106_playback_unknown_ops = {
|
||||
.pointer = snd_ca0106_pcm_pointer_playback,
|
||||
};
|
||||
|
||||
static struct snd_pcm_ops snd_ca0106_playback_rear_ops = {
|
||||
static const struct snd_pcm_ops snd_ca0106_playback_rear_ops = {
|
||||
.open = snd_ca0106_pcm_open_playback_rear,
|
||||
.close = snd_ca0106_pcm_close_playback,
|
||||
.ioctl = snd_pcm_lib_ioctl,
|
||||
|
Referência em uma nova issue
Block a user