powerpc: use non-racy method for proc entries creation
Use proc_create()/proc_create_data() to make sure that ->proc_fops and ->data be setup before gluing PDE to main tree. Add correct ->owner to proc_fops to fix reading/module unloading race. Signed-off-by: Denis V. Lunev <den@openvz.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Alexey Dobriyan <adobriyan@gmail.com> Cc: "Eric W. Biederman" <ebiederm@xmission.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:

committed by
Linus Torvalds

vanhempi
6f1c86ec31
commit
667471386d
@@ -180,15 +180,10 @@ static const struct file_operations proc_viopath_operations = {
|
||||
|
||||
static int __init vio_proc_init(void)
|
||||
{
|
||||
struct proc_dir_entry *e;
|
||||
|
||||
if (!firmware_has_feature(FW_FEATURE_ISERIES))
|
||||
return 0;
|
||||
|
||||
e = create_proc_entry("iSeries/config", 0, NULL);
|
||||
if (e)
|
||||
e->proc_fops = &proc_viopath_operations;
|
||||
|
||||
proc_create("iSeries/config", 0, NULL, &proc_viopath_operations);
|
||||
return 0;
|
||||
}
|
||||
__initcall(vio_proc_init);
|
||||
|
Viittaa uudesa ongelmassa
Block a user