drm/i915: Move Valleyview DP DPLL divisor calc to intel_dp_set_clock v2
For DP pll settings, there is only two golden configs. Instead of running through the algorithm to determine it, hardcode the value and get it determine in intel_dp_set_clock. v2: Rework on the intel_limit compiler warning. (Jani) Signed-off-by: Chon Ming Lee <chon.ming.lee@intel.com> [danvet: Fix up checkpatch issues.] Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This commit is contained in:

committed by
Daniel Vetter

parent
9dd4ffdf39
commit
65ce4bf5a1
@@ -339,19 +339,6 @@ static const intel_limit_t intel_limits_vlv_hdmi = {
|
|||||||
.p2_slow = 2, .p2_fast = 20 },
|
.p2_slow = 2, .p2_fast = 20 },
|
||||||
};
|
};
|
||||||
|
|
||||||
static const intel_limit_t intel_limits_vlv_dp = {
|
|
||||||
.dot = { .min = 25000, .max = 270000 },
|
|
||||||
.vco = { .min = 4000000, .max = 6000000 },
|
|
||||||
.n = { .min = 1, .max = 7 },
|
|
||||||
.m = { .min = 22, .max = 450 },
|
|
||||||
.m1 = { .min = 2, .max = 3 },
|
|
||||||
.m2 = { .min = 11, .max = 156 },
|
|
||||||
.p = { .min = 10, .max = 30 },
|
|
||||||
.p1 = { .min = 1, .max = 3 },
|
|
||||||
.p2 = { .dot_limit = 270000,
|
|
||||||
.p2_slow = 2, .p2_fast = 20 },
|
|
||||||
};
|
|
||||||
|
|
||||||
static const intel_limit_t *intel_ironlake_limit(struct drm_crtc *crtc,
|
static const intel_limit_t *intel_ironlake_limit(struct drm_crtc *crtc,
|
||||||
int refclk)
|
int refclk)
|
||||||
{
|
{
|
||||||
@@ -414,10 +401,8 @@ static const intel_limit_t *intel_limit(struct drm_crtc *crtc, int refclk)
|
|||||||
} else if (IS_VALLEYVIEW(dev)) {
|
} else if (IS_VALLEYVIEW(dev)) {
|
||||||
if (intel_pipe_has_type(crtc, INTEL_OUTPUT_ANALOG))
|
if (intel_pipe_has_type(crtc, INTEL_OUTPUT_ANALOG))
|
||||||
limit = &intel_limits_vlv_dac;
|
limit = &intel_limits_vlv_dac;
|
||||||
else if (intel_pipe_has_type(crtc, INTEL_OUTPUT_HDMI))
|
|
||||||
limit = &intel_limits_vlv_hdmi;
|
|
||||||
else
|
else
|
||||||
limit = &intel_limits_vlv_dp;
|
limit = &intel_limits_vlv_hdmi;
|
||||||
} else if (!IS_GEN2(dev)) {
|
} else if (!IS_GEN2(dev)) {
|
||||||
if (intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS))
|
if (intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS))
|
||||||
limit = &intel_limits_i9xx_lvds;
|
limit = &intel_limits_i9xx_lvds;
|
||||||
@@ -4896,7 +4881,7 @@ static int i9xx_crtc_mode_set(struct drm_crtc *crtc,
|
|||||||
|
|
||||||
refclk = i9xx_get_refclk(crtc, num_connectors);
|
refclk = i9xx_get_refclk(crtc, num_connectors);
|
||||||
|
|
||||||
if (!is_dsi) {
|
if (!is_dsi && !intel_crtc->config.clock_set) {
|
||||||
/*
|
/*
|
||||||
* Returns a set of divisors for the desired target clock with
|
* Returns a set of divisors for the desired target clock with
|
||||||
* the given refclk, or FALSE. The returned values represent
|
* the given refclk, or FALSE. The returned values represent
|
||||||
@@ -4923,6 +4908,7 @@ static int i9xx_crtc_mode_set(struct drm_crtc *crtc,
|
|||||||
* by using the FP0/FP1. In such case we will disable the LVDS
|
* by using the FP0/FP1. In such case we will disable the LVDS
|
||||||
* downclock feature.
|
* downclock feature.
|
||||||
*/
|
*/
|
||||||
|
limit = intel_limit(crtc, refclk);
|
||||||
has_reduced_clock =
|
has_reduced_clock =
|
||||||
dev_priv->display.find_dpll(limit, crtc,
|
dev_priv->display.find_dpll(limit, crtc,
|
||||||
dev_priv->lvds_downclock,
|
dev_priv->lvds_downclock,
|
||||||
|
@@ -57,6 +57,13 @@ static const struct dp_link_dpll pch_dpll[] = {
|
|||||||
{ .p1 = 1, .p2 = 10, .n = 2, .m1 = 14, .m2 = 8 } }
|
{ .p1 = 1, .p2 = 10, .n = 2, .m1 = 14, .m2 = 8 } }
|
||||||
};
|
};
|
||||||
|
|
||||||
|
static const struct dp_link_dpll vlv_dpll[] = {
|
||||||
|
{ DP_LINK_BW_1_62,
|
||||||
|
{ .p1 = 3, .p2 = 2, .n = 5, .m1 = 5, .m2 = 3 } },
|
||||||
|
{ DP_LINK_BW_2_7,
|
||||||
|
{ .p1 = 2, .p2 = 2, .n = 1, .m1 = 2, .m2 = 27 } }
|
||||||
|
};
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* is_edp - is the given port attached to an eDP panel (either CPU or PCH)
|
* is_edp - is the given port attached to an eDP panel (either CPU or PCH)
|
||||||
* @intel_dp: DP struct
|
* @intel_dp: DP struct
|
||||||
@@ -680,7 +687,8 @@ intel_dp_set_clock(struct intel_encoder *encoder,
|
|||||||
divisor = pch_dpll;
|
divisor = pch_dpll;
|
||||||
count = ARRAY_SIZE(pch_dpll);
|
count = ARRAY_SIZE(pch_dpll);
|
||||||
} else if (IS_VALLEYVIEW(dev)) {
|
} else if (IS_VALLEYVIEW(dev)) {
|
||||||
/* FIXME: Need to figure out optimized DP clocks for vlv. */
|
divisor = vlv_dpll;
|
||||||
|
count = ARRAY_SIZE(vlv_dpll);
|
||||||
}
|
}
|
||||||
|
|
||||||
if (divisor && count) {
|
if (divisor && count) {
|
||||||
|
Reference in New Issue
Block a user