xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mtd: kill MTD_NAND_VERIFY_WRITE

Browse Source 
Just as Artem suggested:

"Both UBI and JFFS2 are able to read verify what they wrote already.
There are also MTD tests which do this verification. So I think there
is no reason to keep this in the NAND layer, let alone wasting RAM in
the driver to support this feature. Besides, it does not work for sub-pages
and many drivers have it broken. It hurts more than it provides benefits."

So kill MTD_NAND_VERIFY_WRITE entirely.

Signed-off-by: Huang Shijie <shijie8@gmail.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
This commit is contained in:
Huang Shijie
2012-08-14 22:38:45 -04:00
committed by David Woodhouse
parent 8da28681eb
commit 657f28f881
26 changed files with 0 additions and 550 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
drivers/mtd/nand/lpc32xx_slc.c
View File

@@ -368,24 +368,6 @@ static void lpc32xx_nand_write_buf(struct mtd_info *mtd, const uint8_t *buf, int
writel((uint32_t)*buf++, SLC_DATA(host->io_base));
}
/*
* Verify data in buffer to data on device
*/
static int lpc32xx_verify_buf(struct mtd_info *mtd, const uint8_t *buf, int len)
{
struct nand_chip *chip = mtd->priv;
struct lpc32xx_nand_host *host = chip->priv;
int i;
/* DATA register must be read as 32 bits or it will fail */
for (i = 0; i < len; i++) {
if (buf[i] != (uint8_t)readl(SLC_DATA(host->io_base)))
return -EFAULT;
}
return 0;
}
/*
* Read the OOB data from the device without ECC using FIFO method
*/
@@ -871,7 +853,6 @@ static int __devinit lpc32xx_nand_probe(struct platform_device *pdev)
chip->ecc.correct = nand_correct_data;
chip->ecc.strength = 1;
chip->ecc.hwctl = lpc32xx_nand_ecc_enable;
chip->verify_buf = lpc32xx_verify_buf;
/* bitflip_threshold's default is defined as ecc_strength anyway.
* Unfortunately, it is set only later at add_mtd_device(). Meanwhile