nilfs2: remove header file for segment list operations
This will eliminate obsolete list operations of nilfs_segment_entry structure which has been used to handle mutiple segment numbers. The patch ("nilfs2: remove list of freeing segments") removed use of the structure from the segment constructor code, and this patch simplifies the remaining code by integrating it into recovery.c. Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
This commit is contained in:
@@ -28,7 +28,6 @@
|
||||
#include "segment.h"
|
||||
#include "sufile.h"
|
||||
#include "page.h"
|
||||
#include "seglist.h"
|
||||
#include "segbuf.h"
|
||||
|
||||
/*
|
||||
@@ -395,6 +394,24 @@ static void dispose_recovery_list(struct list_head *head)
|
||||
}
|
||||
}
|
||||
|
||||
struct nilfs_segment_entry {
|
||||
struct list_head list;
|
||||
__u64 segnum;
|
||||
};
|
||||
|
||||
static int nilfs_segment_list_add(struct list_head *head, __u64 segnum)
|
||||
{
|
||||
struct nilfs_segment_entry *ent = kmalloc(sizeof(*ent), GFP_NOFS);
|
||||
|
||||
if (unlikely(!ent))
|
||||
return -ENOMEM;
|
||||
|
||||
ent->segnum = segnum;
|
||||
INIT_LIST_HEAD(&ent->list);
|
||||
list_add_tail(&ent->list, head);
|
||||
return 0;
|
||||
}
|
||||
|
||||
void nilfs_dispose_segment_list(struct list_head *head)
|
||||
{
|
||||
while (!list_empty(head)) {
|
||||
@@ -402,7 +419,7 @@ void nilfs_dispose_segment_list(struct list_head *head)
|
||||
= list_entry(head->next,
|
||||
struct nilfs_segment_entry, list);
|
||||
list_del(&ent->list);
|
||||
nilfs_free_segment_entry(ent);
|
||||
kfree(ent);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -431,12 +448,10 @@ static int nilfs_prepare_segment_for_recovery(struct the_nilfs *nilfs,
|
||||
if (unlikely(err))
|
||||
goto failed;
|
||||
|
||||
err = -ENOMEM;
|
||||
for (i = 1; i < 4; i++) {
|
||||
ent = nilfs_alloc_segment_entry(segnum[i]);
|
||||
if (unlikely(!ent))
|
||||
err = nilfs_segment_list_add(head, segnum[i]);
|
||||
if (unlikely(err))
|
||||
goto failed;
|
||||
list_add_tail(&ent->list, head);
|
||||
}
|
||||
|
||||
/*
|
||||
@@ -450,7 +465,7 @@ static int nilfs_prepare_segment_for_recovery(struct the_nilfs *nilfs,
|
||||
goto failed;
|
||||
}
|
||||
list_del(&ent->list);
|
||||
nilfs_free_segment_entry(ent);
|
||||
kfree(ent);
|
||||
}
|
||||
|
||||
/* Allocate new segments for recovery */
|
||||
@@ -791,7 +806,6 @@ int nilfs_search_super_root(struct the_nilfs *nilfs, struct nilfs_sb_info *sbi,
|
||||
u64 seg_seq;
|
||||
__u64 segnum, nextnum = 0;
|
||||
__u64 cno;
|
||||
struct nilfs_segment_entry *ent;
|
||||
LIST_HEAD(segments);
|
||||
int empty_seg = 0, scan_newer = 0;
|
||||
int ret;
|
||||
@@ -892,12 +906,9 @@ int nilfs_search_super_root(struct the_nilfs *nilfs, struct nilfs_sb_info *sbi,
|
||||
if (empty_seg++)
|
||||
goto super_root_found; /* found a valid super root */
|
||||
|
||||
ent = nilfs_alloc_segment_entry(segnum);
|
||||
if (unlikely(!ent)) {
|
||||
ret = -ENOMEM;
|
||||
ret = nilfs_segment_list_add(&segments, segnum);
|
||||
if (unlikely(ret))
|
||||
goto failed;
|
||||
}
|
||||
list_add_tail(&ent->list, &segments);
|
||||
|
||||
seg_seq++;
|
||||
segnum = nextnum;
|
||||
|
Reference in New Issue
Block a user