mtd: rawnand: Mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/mtd/nand/raw/diskonchip.c: In function ‘doc_probe’: ./include/linux/printk.h:303:2: warning: this statement may fall through [-Wimplicit-fallthrough=] printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/mtd/nand/raw/diskonchip.c:1479:4: note: in expansion of macro ‘pr_err’ pr_err("DiskOnChip Millennium Plus 32MB is not supported, ignoring.\n"); ^~~~~~ drivers/mtd/nand/raw/diskonchip.c:1480:3: note: here default: ^~~~~~~ drivers/mtd/nand/raw/nandsim.c: In function ‘ns_init_module’: drivers/mtd/nand/raw/nandsim.c:2254:22: warning: this statement may fall through [-Wimplicit-fallthrough=] chip->bbt_options |= NAND_BBT_NO_OOB; drivers/mtd/nand/raw/nandsim.c:2255:2: note: here case 1: ^~~~ drivers/mtd/nand/raw/nuc900_nand.c: In function ‘nuc900_nand_command_lp’: ./arch/x86/include/asm/io.h:91:22: warning: this statement may fall through [-Wimplicit-fallthrough=] #define __raw_writel __writel drivers/mtd/nand/raw/nuc900_nand.c:52:2: note: in expansion of macro ‘__raw_writel’ __raw_writel((val), (dev)->reg + REG_SMCMD) ^~~~~~~~~~~~ drivers/mtd/nand/raw/nuc900_nand.c:196:3: note: in expansion of macro ‘write_cmd_reg’ write_cmd_reg(nand, NAND_CMD_READSTART); ^~~~~~~~~~~~~ drivers/mtd/nand/raw/nuc900_nand.c:197:2: note: here default: ^~~~~~~ drivers/mtd/nand/raw/omap_elm.c: In function ‘elm_context_restore’: drivers/mtd/nand/raw/omap_elm.c:512:4: warning: this statement may fall through [-Wimplicit-fallthrough=] elm_write_reg(info, ELM_SYNDROME_FRAGMENT_4 + offset, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ regs->elm_syndrome_fragment_4[i]); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/mtd/nand/raw/omap_elm.c:514:3: note: here case BCH8_ECC: ^~~~ drivers/mtd/nand/raw/omap_elm.c:517:4: warning: this statement may fall through [-Wimplicit-fallthrough=] elm_write_reg(info, ELM_SYNDROME_FRAGMENT_2 + offset, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ regs->elm_syndrome_fragment_2[i]); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/mtd/nand/raw/omap_elm.c:519:3: note: here case BCH4_ECC: ^~~~ drivers/mtd/nand/raw/omap_elm.c: In function ‘elm_context_save’: drivers/mtd/nand/raw/omap_elm.c:466:37: warning: this statement may fall through [-Wimplicit-fallthrough=] regs->elm_syndrome_fragment_4[i] = elm_read_reg(info, ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~ ELM_SYNDROME_FRAGMENT_4 + offset); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/mtd/nand/raw/omap_elm.c:468:3: note: here case BCH8_ECC: ^~~~ drivers/mtd/nand/raw/omap_elm.c:471:37: warning: this statement may fall through [-Wimplicit-fallthrough=] regs->elm_syndrome_fragment_2[i] = elm_read_reg(info, ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~ ELM_SYNDROME_FRAGMENT_2 + offset); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/mtd/nand/raw/omap_elm.c:473:3: note: here case BCH4_ECC: ^~~~ Warning level 3 was used: -Wimplicit-fallthrough=3 This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
This commit is contained in:

committed by
Miquel Raynal

parent
f67ed1461e
commit
64f1da10ca
@@ -1477,6 +1477,7 @@ static int __init doc_probe(unsigned long physadr)
|
|||||||
break;
|
break;
|
||||||
case DOC_ChipID_DocMilPlus32:
|
case DOC_ChipID_DocMilPlus32:
|
||||||
pr_err("DiskOnChip Millennium Plus 32MB is not supported, ignoring.\n");
|
pr_err("DiskOnChip Millennium Plus 32MB is not supported, ignoring.\n");
|
||||||
|
/* fall through */
|
||||||
default:
|
default:
|
||||||
ret = -ENODEV;
|
ret = -ENODEV;
|
||||||
goto notfound;
|
goto notfound;
|
||||||
|
@@ -2251,9 +2251,11 @@ static int __init ns_init_module(void)
|
|||||||
|
|
||||||
switch (bbt) {
|
switch (bbt) {
|
||||||
case 2:
|
case 2:
|
||||||
chip->bbt_options |= NAND_BBT_NO_OOB;
|
chip->bbt_options |= NAND_BBT_NO_OOB;
|
||||||
|
/* fall through */
|
||||||
case 1:
|
case 1:
|
||||||
chip->bbt_options |= NAND_BBT_USE_FLASH;
|
chip->bbt_options |= NAND_BBT_USE_FLASH;
|
||||||
|
/* fall through */
|
||||||
case 0:
|
case 0:
|
||||||
break;
|
break;
|
||||||
default:
|
default:
|
||||||
|
@@ -192,8 +192,9 @@ static void nuc900_nand_command_lp(struct nand_chip *chip,
|
|||||||
return;
|
return;
|
||||||
|
|
||||||
case NAND_CMD_READ0:
|
case NAND_CMD_READ0:
|
||||||
|
|
||||||
write_cmd_reg(nand, NAND_CMD_READSTART);
|
write_cmd_reg(nand, NAND_CMD_READSTART);
|
||||||
|
/* fall through */
|
||||||
|
|
||||||
default:
|
default:
|
||||||
|
|
||||||
if (!chip->legacy.dev_ready) {
|
if (!chip->legacy.dev_ready) {
|
||||||
|
@@ -465,11 +465,13 @@ static int elm_context_save(struct elm_info *info)
|
|||||||
ELM_SYNDROME_FRAGMENT_5 + offset);
|
ELM_SYNDROME_FRAGMENT_5 + offset);
|
||||||
regs->elm_syndrome_fragment_4[i] = elm_read_reg(info,
|
regs->elm_syndrome_fragment_4[i] = elm_read_reg(info,
|
||||||
ELM_SYNDROME_FRAGMENT_4 + offset);
|
ELM_SYNDROME_FRAGMENT_4 + offset);
|
||||||
|
/* fall through */
|
||||||
case BCH8_ECC:
|
case BCH8_ECC:
|
||||||
regs->elm_syndrome_fragment_3[i] = elm_read_reg(info,
|
regs->elm_syndrome_fragment_3[i] = elm_read_reg(info,
|
||||||
ELM_SYNDROME_FRAGMENT_3 + offset);
|
ELM_SYNDROME_FRAGMENT_3 + offset);
|
||||||
regs->elm_syndrome_fragment_2[i] = elm_read_reg(info,
|
regs->elm_syndrome_fragment_2[i] = elm_read_reg(info,
|
||||||
ELM_SYNDROME_FRAGMENT_2 + offset);
|
ELM_SYNDROME_FRAGMENT_2 + offset);
|
||||||
|
/* fall through */
|
||||||
case BCH4_ECC:
|
case BCH4_ECC:
|
||||||
regs->elm_syndrome_fragment_1[i] = elm_read_reg(info,
|
regs->elm_syndrome_fragment_1[i] = elm_read_reg(info,
|
||||||
ELM_SYNDROME_FRAGMENT_1 + offset);
|
ELM_SYNDROME_FRAGMENT_1 + offset);
|
||||||
@@ -511,11 +513,13 @@ static int elm_context_restore(struct elm_info *info)
|
|||||||
regs->elm_syndrome_fragment_5[i]);
|
regs->elm_syndrome_fragment_5[i]);
|
||||||
elm_write_reg(info, ELM_SYNDROME_FRAGMENT_4 + offset,
|
elm_write_reg(info, ELM_SYNDROME_FRAGMENT_4 + offset,
|
||||||
regs->elm_syndrome_fragment_4[i]);
|
regs->elm_syndrome_fragment_4[i]);
|
||||||
|
/* fall through */
|
||||||
case BCH8_ECC:
|
case BCH8_ECC:
|
||||||
elm_write_reg(info, ELM_SYNDROME_FRAGMENT_3 + offset,
|
elm_write_reg(info, ELM_SYNDROME_FRAGMENT_3 + offset,
|
||||||
regs->elm_syndrome_fragment_3[i]);
|
regs->elm_syndrome_fragment_3[i]);
|
||||||
elm_write_reg(info, ELM_SYNDROME_FRAGMENT_2 + offset,
|
elm_write_reg(info, ELM_SYNDROME_FRAGMENT_2 + offset,
|
||||||
regs->elm_syndrome_fragment_2[i]);
|
regs->elm_syndrome_fragment_2[i]);
|
||||||
|
/* fall through */
|
||||||
case BCH4_ECC:
|
case BCH4_ECC:
|
||||||
elm_write_reg(info, ELM_SYNDROME_FRAGMENT_1 + offset,
|
elm_write_reg(info, ELM_SYNDROME_FRAGMENT_1 + offset,
|
||||||
regs->elm_syndrome_fragment_1[i]);
|
regs->elm_syndrome_fragment_1[i]);
|
||||||
|
Reference in New Issue
Block a user