net: x25: fix one potential use-after-free issue
The function x25_init is not properly unregister related resources on error handler.It is will result in kernel oops if x25_init init failed, so add properly unregister call on error handler. Also, i adjust the coding style and make x25_register_sysctl properly return failure. Signed-off-by: linzhang <xiaolou4617@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
3c2ce60bdd
commit
64df6d525f
@@ -298,10 +298,10 @@ void x25_check_rbuf(struct sock *);
|
||||
|
||||
/* sysctl_net_x25.c */
|
||||
#ifdef CONFIG_SYSCTL
|
||||
void x25_register_sysctl(void);
|
||||
int x25_register_sysctl(void);
|
||||
void x25_unregister_sysctl(void);
|
||||
#else
|
||||
static inline void x25_register_sysctl(void) {};
|
||||
static inline int x25_register_sysctl(void) { return 0; };
|
||||
static inline void x25_unregister_sysctl(void) {};
|
||||
#endif /* CONFIG_SYSCTL */
|
||||
|
||||
|
Reference in New Issue
Block a user